Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use correct After-queryParam when none specified #188

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Nov 24, 2024

Motivation

Fixes an issue where the after param is after the before param due to the week starting on Tuesdays. I.e. https://hephaestus.ase.cit.tum.de redirects to https://hephaestus.ase.cit.tum.de/?after=2024-11-26T09:00:00%2B01:00&before=2024-11-25T00:22:47%2B01:00 right now, making the default leaderboard data incorrect.

Description

This fix moves the default date configuration to the leaderboard filter component, making sure dates are only changed in one place of the application.
Also fixes a small bug regarding the recently merged PR #124, where the default value of the Team-Color-Input had an invalid default value:
Screenshot 2024-11-25 000613

Testing Instructions

  • Run application-server and webapp
  • Go to http://localhost:4200/ and check if the default leaderboard uses the correct timeframe.

Screenshots (if applicable)

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

@GODrums GODrums added bug Something isn't working priority:critical Urgent tasks needing immediate resolution. labels Nov 24, 2024
@GODrums GODrums self-assigned this Nov 24, 2024
@github-actions github-actions bot added client size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 24, 2024
@FelixTJDietrich FelixTJDietrich merged commit 0e8e39d into develop Nov 24, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/default-leaderboard-date branch November 24, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client priority:critical Urgent tasks needing immediate resolution. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants