Fix: Use correct After-queryParam when none specified #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes an issue where the after param is after the before param due to the week starting on Tuesdays. I.e. https://hephaestus.ase.cit.tum.de redirects to https://hephaestus.ase.cit.tum.de/?after=2024-11-26T09:00:00%2B01:00&before=2024-11-25T00:22:47%2B01:00 right now, making the default leaderboard data incorrect.
Description
This fix moves the default date configuration to the leaderboard filter component, making sure dates are only changed in one place of the application.
Also fixes a small bug regarding the recently merged PR #124, where the default value of the Team-Color-Input had an invalid default value:
Testing Instructions
application-server
andwebapp
http://localhost:4200/
and check if the default leaderboard uses the correct timeframe.Screenshots (if applicable)
Checklist
General