Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Configuration to webapp #206

Merged
merged 16 commits into from
Dec 8, 2024
Merged

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Dec 4, 2024

Motivation

Solves task 2 of #202.

Description

This PR adds Sentry to the Angular webapp:

Testing Instructions

Locally:

  • Set environment to prod in environment.ts
  • Disable all content filter and ad blocker (especially UBlock)
  • Open the developer tools of your browser
  • Open the network tap & Reload the site once
  • Search for sentry, check if all request to sentry are successful (status code 200)
  • Optionally: throw a sample error (e.g. on button click) and check if it appears on Sentry

On Sentry:

Example test errors:

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added enhancement New feature or request client labels Dec 4, 2024
@GODrums GODrums self-assigned this Dec 4, 2024
@github-actions github-actions bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 4, 2024
Copy link
Contributor

@iam-flo iam-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check code quality check comments

@GODrums GODrums marked this pull request as draft December 4, 2024 21:27
@GODrums
Copy link
Collaborator Author

GODrums commented Dec 4, 2024

Check code quality check comments

Sorry, I meant to mark this PR as draft. I still want to add source map uploading before it would be ready to merge.

@GODrums GODrums mentioned this pull request Dec 4, 2024
3 tasks
@GODrums GODrums marked this pull request as ready for review December 7, 2024 02:21
@GODrums GODrums requested a review from iam-flo December 7, 2024 02:21
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@FelixTJDietrich FelixTJDietrich merged commit 46867d8 into develop Dec 8, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the 202-sentry-angular branch December 8, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants