-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA/Lint: Prettier + ESLint for the webapp #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting it up I have some minor change requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed some of the linting rules and added some new ones, I think you just copied them from Artemis. We can start with the recommended linting rules and then adjust if necessary.
Description
Summary
Adds Prettier + ESLint to the webapp. Configs are similar to the ones used in the Artemis-Repo. Triggers are set to:
/webapp
develop
-branch with changes in/webapp
npm run lint
andnpm run lint:fix
npm run prettier:check
andnpm run prettier:write
This PR does NOT include Prettier formatting / ESL linting fixes yet, only the initial setup to avoid potential merge conflicts.
Motivation
The project should follow consistent code conventions and standards.
Prettier and ESLint are the most common combination in attaining such goals.
Key Changes
.editorconfig
Checklist
TODOs / Next up
General