Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CVA Tailwind Autocomplete #35

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix: CVA Tailwind Autocomplete #35

merged 2 commits into from
Aug 6, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Aug 6, 2024

Summary

This adds the auto-complete feature for Tailwind classes (VSCode's Tailwind IntelliSense extension) to our custom CVA implementation for Angular components.

image

@GODrums GODrums added bug Something isn't working client labels Aug 6, 2024
@GODrums GODrums added this to the Initial Project Setup milestone Aug 6, 2024
@GODrums GODrums self-assigned this Aug 6, 2024
FelixTJDietrich
FelixTJDietrich approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked after restarting VSCode.
We might need further fixing for other cases. I checked computedClass and it also did not give any IntelliSense when adding classes there.

@FelixTJDietrich FelixTJDietrich merged commit 6974320 into develop Aug 6, 2024
1 check passed
@FelixTJDietrich FelixTJDietrich deleted the fix/tailwind-autocomplete branch August 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixTJDietrich FelixTJDietrich FelixTJDietrich approved these changes

Assignees

@GODrums GODrums

Labels
bug Something isn't working client
Projects
None yet
Milestone
Initial Project Setup
Development

Successfully merging this pull request may close these issues.
2 participants
@GODrums @FelixTJDietrich