Add Avatar Component #40
Conversation
GODrums
added
enhancement
| args: { | ||
| size: 'default', | ||
| src: 'foobar.jpg', | ||
| fallback: 'https://placehold.co/40', |
There was a problem hiding this comment.
Works for me, I might try to do a follow-up that uses content projection just to see how that works.
There was a problem hiding this comment.
The disadvantage of the current approach (variables) vs. child-components is of course that it's not possible to use anything other than image URLs.
Spartan's approach of doubled components with child directives was the only alternative I was able to find.
There was a problem hiding this comment.
I think it is possible via contentChild in an app-avatar component and then having app-avatar-image and app-avatar-fallback as children 🤔
|
|
||
| render: (args) => ({ | ||
| props: args, | ||
| template: `<app-avatar ${argsToTemplate(args)}></app-avatar>` |
There was a problem hiding this comment.
I think you can also define the template shared for all stories somehow if it is the same for all.
|
Generally looks good :) |
Description
Add an avatar component with Storybook page.
Fixes #30
Key Changes / Features
NgOptimizedImageto optimize performanceFurther Resources
Checklist
General
Client (if applicable)
Screenshots