Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Spring Modulith in application-server #59

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Aug 15, 2024

Motivation

Spring Modulith allows for module-driven development in a Spring project including internal and API-exposed parts within a module. It provides event management for cross-module communication and integration testing functionality.

Description

Adds the core packages of Spring Modulith to the Application Server.
Added tests include a module integrity verification (according to https://docs.spring.io/spring-modulith/reference/verification.html) as well as UML diagram generation.

Resources for used modules/JARs

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@GODrums GODrums added enhancement New feature or request application-server labels Aug 15, 2024
@GODrums GODrums added this to the Initial Project Setup milestone Aug 15, 2024
@GODrums GODrums self-assigned this Aug 15, 2024
@github-actions github-actions bot added feature size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 15, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTJDietrich FelixTJDietrich merged commit d46377e into develop Aug 16, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/spring-modulithic branch August 16, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server enhancement New feature or request feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants