Development: Add Sentry reporting for the pipelines
#135
Conversation
Hialus
requested review from
kaancayli and
yassinsws
and removed request for
kaancayli
|
Warning Review failedThe pull request is closed. WalkthroughThis update enhances error handling and logging across several modules in the application. Exception details are now included in error messages, and Changes
Sequence Diagram(s)ExerciseChatPipeline Error Handling sequenceDiagram
participant User
participant ChatPipeline as ExerciseChatPipeline
participant Status as StatusUpdater
participant Sentry as Sentry SDK
User->>ChatPipeline: Execute Pipeline
ChatPipeline->>ChatPipeline: _run_exercise_chat_pipeline()
ChatPipeline->>ChatPipeline: Generates Exception (e)
ChatPipeline->>Status: error("Failed to generate response: {e}", exception=e)
Status->>Sentry: capture_exception(e)
Status->>User: Return Error Response
LectureIngestionPipeline Error Handling sequenceDiagram
participant User
participant LecturePipeline as LectureIngestionPipeline
participant Status as StatusUpdater
participant Sentry as Sentry SDK
User->>LecturePipeline: Start Ingestion
LecturePipeline->>LecturePipeline: __call__()
LecturePipeline->>LecturePipeline: Generates Exception (e)
LecturePipeline->>Status: error("Failed to ingest lectures: {e}", exception=e)
Status->>Sentry: capture_exception(e)
Status->>User: Return Error Response
Tip AI model upgrade
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
app/pipeline/lecture_ingestion_pipeline.py (4)
Line range hint
129-129: Rename unused loop control variable.The loop control variable
iis not used within the loop body. Renameito_ito indicate it is unused.- for i, lecture_unit in enumerate(self.dto.lecture_units): + for _i, lecture_unit in enumerate(self.dto.lecture_units):
Line range hint
162-163: Use a singlewithstatement for multiple contexts.Use a single
withstatement with multiple contexts instead of nestedwithstatements.- with self.collection.batch.rate_limit(requests_per_minute=600) as batch: - try: - for index, chunk in enumerate(chunks): + with self.collection.batch.rate_limit(requests_per_minute=600) as batch, batch: + try: + for _index, chunk in enumerate(chunks):
Line range hint
165-165: Rename unused loop control variable.The loop control variable
indexis not used within the loop body. Renameindexto_indexto indicate it is unused.- for index, chunk in enumerate(chunks): + for _index, chunk in enumerate(chunks):
Line range hint
263-263: Remove unnecessary open mode parameters.The open mode parameters are unnecessary and can be removed.
- with open(prompt_file_path, "r") as file: + with open(prompt_file_path) as file:
# Conflicts: # app/pipeline/chat/course_chat_pipeline.py
Hialus
dismissed stale reviews from MichaelOwenDyer and coderabbitai[bot]
via
1b05599
Summary by CodeRabbit
Bug Fixes
Chores
capture_exceptionfromsentry_sdkfor better error monitoring and reporting.