Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/index and parenthesis bug fixes #138

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

yassinsws
Copy link
Contributor

@yassinsws yassinsws commented Jul 9, 2024

This Pull request fixes these two bugs, one is the index out-of-range error, and the other is "{" found in the field name from Langchain.
It also makes minor refactoring for the prompt.
Here are the links for the bugs :
https://sentry.ase.in.tum.de/organizations/artemis/issues/44034/?project=7&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d
https://sentry.ase.in.tum.de/organizations/artemis/issues/44095/?query=is%3Aunresolved&referrer=issue-stream

Summary by CodeRabbit

  • New Features

    • Improved response instructions to include paragraph numbers only when necessary.
  • Updates

    • Enhanced chat pipeline to better handle relevant text chunks.
    • Upgraded the GPT version requirement from 3.5 to 4 for improved processing.
    • Adjusted retrieval logic for better accuracy and performance.
  • Bug Fixes

    • Corrected the error handling and skip functionality to assign results to the status attribute properly.

Copy link
Contributor

coderabbitai bot commented Jul 9, 2024

Walkthrough

The changes primarily involve updates to methods and parameters across various modules to refine functionality and ensure accurate status tracking and information retrieval. Key modifications include altering text handling in prompts, updating default parameters, and refining error handling and status updates in web services.

Changes

Files Change Summary
.../app/pipeline/chat/exercise_chat_pipeline.py Modified _add_relevant_chunks_to_prompt to alter txt variable before using SystemMessagePromptTemplate.from_template.
.../app/pipeline/prompts/reranker_prompt.txt Refined instructions on including paragraph numbers in the JSON response.
.../app/pipeline/shared/reranker_pipeline.py Updated gpt_version_equivalent in CapabilityRequestHandler from 3.5 to 4.
.../app/retrieval/lecture_retrieval.py Added conditional check in __call__ method and adjusted hybrid_factor in run_parallel_rewrite_tasks method.
.../app/web/status/status_update.py Modified error and skip methods to assign result to status instead of stage.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
app/pipeline/prompts/reranker_prompt.txt (1)

6-6: Ensure clarity in instructions.

The instruction is clear but can be made more concise. Consider rephrasing to: "Only include paragraph numbers if necessary for answering the student's question; otherwise, leave the array empty."

coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 9, 2024
@yassinsws yassinsws changed the title Bugfix/index parenthesis bug fixes Bugfix/index and parenthesis bug fixes Jul 9, 2024
@Hialus Hialus merged commit ace007c into main Jul 11, 2024
5 checks passed
@Hialus Hialus deleted the bugfix/index_parenthesis_bugs-fixes branch July 11, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants