-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/index and parenthesis bug fixes #138
Conversation
WalkthroughThe changes primarily involve updates to methods and parameters across various modules to refine functionality and ensure accurate status tracking and information retrieval. Key modifications include altering text handling in prompts, updating default parameters, and refining error handling and status updates in web services. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
app/pipeline/prompts/reranker_prompt.txt (1)
6-6
: Ensure clarity in instructions.The instruction is clear but can be made more concise. Consider rephrasing to: "Only include paragraph numbers if necessary for answering the student's question; otherwise, leave the array empty."
This Pull request fixes these two bugs, one is the index out-of-range error, and the other is "{" found in the field name from Langchain.
It also makes minor refactoring for the prompt.
Here are the links for the bugs :
https://sentry.ase.in.tum.de/organizations/artemis/issues/44034/?project=7&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d
https://sentry.ase.in.tum.de/organizations/artemis/issues/44095/?query=is%3Aunresolved&referrer=issue-stream
Summary by CodeRabbit
New Features
Updates
Bug Fixes