-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add V2 Messages Endpoint
#34
Conversation
Tried running the formatter but can't seem to get the formatting checks to pass |
you can try to run this |
@MichaelOwenDyer I think the endpoint Other than this, this PR LGTM |
You're right, it will break production. There is another PR open on Artemis to change that side as well. But it might actually be smarter to just create a /v2/ endpoint, that way this can be merged without Artemis breaking. |
That is a great idea. I think this would make sense here for the transition phase, until Artemis Prod is updated. Then we could simply remove the v1 endpoint afterwards. |
Thanks for the reviews guys. I addressed the issues you pointed out, V1 API should be behaving equivalent to before (although the logic for getting the response variable is now local to the endpoint and not directly in the guidance wrapper). I also extended the message test to test both v1 and v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that you could change this to a v1/v2 split!
Code changes look good, but the linter job is currently failing. Please fix that.
You got it sir. Those dangerously long comments have been shortened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM!
Development
: Add V2 Messages API
Development
: Add V2 Messages APIDevelopment
: Add V2 Messages Endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good to me and since it has been deployed to the test server for some time without issues it also is sufficiently tested now.
Great job 🚀
This PR introduces a version 2 of the messages endpoint, which returns all content generated in a guidance program as opposed to just the one variable titled 'response', and additionally accepts just a string as the template parameter instead of an object containing a string and an unused id.