Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix several issues relating to GPT4 #49

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Jan 8, 2024

Pyris was having severe issues in production environments when trying to use GPT4. I've been debugging this over several weeks and found 3 separate issues at play:

  • A while back we added some caching for guidance objects, which guidance did not properly support in concurrent contexts -> Removed
  • Guidance also does not like it if there are concurrent requests en masse, like the health check produces them -> Added a lock for the health check
  • The OpenAI API returns None as the message for empty messages. Guidance did not support this -> Manually overrode guidance function

@Hialus Hialus self-assigned this Jan 8, 2024
@Hialus Hialus changed the title Bugfix: Fix prod issues Bugfix: Fix several issues relating to GPT4 Jan 8, 2024
@Hialus Hialus marked this pull request as ready for review January 8, 2024 13:36
@Hialus Hialus requested a review from MichaelOwenDyer January 8, 2024 13:36
Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!!

@Hialus Hialus temporarily deployed to Iris Test January 19, 2024 16:49 Inactive
@Hialus Hialus merged commit fd2b726 into main Feb 7, 2024
4 checks passed
@Hialus Hialus deleted the bugfix/fix-gpt4-issues branch February 7, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants