Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM: Use pydantic for config parsing #52

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Feb 11, 2024

Follow up to #51 to replace the manual config parsing with pydantic.

@Hialus Hialus force-pushed the feature/llm-subsystem-pydantic branch from 7acb1c8 to b06d20f Compare February 11, 2024 17:01
kaancayli
kaancayli previously approved these changes Feb 11, 2024
Copy link
Contributor

@kaancayli kaancayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hialus Hialus added the stacked-pr PR that depends on another PR label Feb 11, 2024
@Hialus Hialus added this to the 1.0.0-Prototype milestone Feb 11, 2024
yassinsws
yassinsws previously approved these changes Feb 12, 2024
Copy link
Contributor

@yassinsws yassinsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Base automatically changed from feature/llm-subsystem-v1 to main February 12, 2024 10:44
@Hialus Hialus dismissed stale reviews from yassinsws and kaancayli February 12, 2024 10:44

The base branch was changed.

# Conflicts:
#	app/llm/basic_request_handler.py
#	app/llm/llm_manager.py
#	app/llm/wrapper/__init__.py
#	app/llm/wrapper/abstract_llm_wrapper.py
#	app/llm/wrapper/ollama_wrapper.py
#	app/llm/wrapper/open_ai_chat_wrapper.py
#	app/llm/wrapper/open_ai_completion_wrapper.py
#	app/llm/wrapper/open_ai_embedding_wrapper.py
@Hialus Hialus merged commit fbb403a into main Feb 12, 2024
2 checks passed
@Hialus Hialus deleted the feature/llm-subsystem-pydantic branch February 12, 2024 10:46
isabellagessl pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:LLM stacked-pr PR that depends on another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants