-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring suggestions #59
Conversation
# Conflicts: # app/llm/basic_request_handler.py # app/llm/request_handler_interface.py # requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands right now you did a lot of changes in the internals of the LLM subsystem. I very clearly stated that the entire internals of the subsystem are subject to change and further improvements. The current implementation is merely a simple first version to use in the development of the pipeline subsystem.
The changes to the RequestHandler are sensible and I'd suggest we implement them, as we already discussed that.
The changes to the LlmManager are entirely unnecessary, as the current implementation will effectively be completely replaced. As it is not part of the public API of the subsystem this is easily doable. So any changes here do not really make much sense.
For the changes about the AbstractLlmWrapper
I'd need to spent some additional time thinking about the best possible name, but as they are internal classes this is not really high priority and can be done at any time.
Also your code fails the linter checks. I'd suggest to install the pre commit hooks.
I have some suggestions for the LLM subsystem code. @Hialus, not trying to step on your toes, every change in this PR is a personal opinion. Could be that I am missing the bigger picture with some of these things, let me know your thoughts. Here's a summary of what I did:
basic_request_handler
that I thought was redundant.completion()
,chat_completion()
,create_embedding()
tocomplete()
,chat()
, andembed()
for consistencyrequirements.txt
to use~=
instead of==
.