Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Improve langchain message converters #65

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Common: Improve langchain message converters #65

merged 5 commits into from
Feb 27, 2024

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Feb 21, 2024

  • Moved them to a separate file in the common package
  • Used Pythons amazing switch statement (called match)

@Hialus Hialus self-assigned this Feb 21, 2024
@Hialus
Merge branch 'main' into feature/python-finally-has-switch-statements
ffa721d 
# Conflicts:
#	app/llm/langchain/iris_langchain_chat_model.py
@Hialus
Move more files
4d152b9
kaancayli
kaancayli previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kaancayli kaancayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved

@Hialus Hialus added this to the 1.0.0-Prototype milestone Feb 21, 2024
yassinsws
yassinsws previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@yassinsws yassinsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

MichaelOwenDyer
MichaelOwenDyer previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match expressions would be nicer but i guess we cant have everything 👍🏽

@Hialus Hialus dismissed stale reviews from MichaelOwenDyer, yassinsws, and kaancayli via 253420a February 27, 2024 01:25
@Hialus Hialus merged commit cc98c90 into main Feb 27, 2024
3 checks passed
@Hialus Hialus deleted the feature/python-finally-has-switch-statements branch February 27, 2024 01:27
isabellagessl pushed a commit that referenced this pull request Nov 11, 2024
@Hialus
Common: Improve langchain message converters (#65)
d2117dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassinsws yassinsws yassinsws left review comments

@MichaelOwenDyer MichaelOwenDyer MichaelOwenDyer left review comments

@kaancayli kaancayli kaancayli left review comments

Assignees

@Hialus Hialus

Labels
component:LLM
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Hialus @kaancayli @MichaelOwenDyer @yassinsws