-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline
: Use capabilities instead of hardcoded LLMs
#95
Conversation
WalkthroughThe recent update focuses on enhancing message conversion and handling across the application, particularly in the domain of chat and pipeline execution. It introduces Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review as they are similar to previous changes (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Pipeline
: Use capabilities instead of hardcoded LLMs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running this I get this error:
pyris-app | File "/app/app/main.py", line 4, in <module>
pyris-app | from app.web.routers.health import router as health_router
pyris-app | File "/app/app/web/routers/__init__.py", line 2, in <module>
pyris-app | from ..routers.pipelines import router as pipelines_router
pyris-app | File "/app/app/web/routers/pipelines.py", line 9, in <module>
pyris-app | from app.pipeline.chat.tutor_chat_pipeline import TutorChatPipeline
pyris-app | File "/app/app/pipeline/chat/tutor_chat_pipeline.py", line 13, in <module>
pyris-app | from common import convert_iris_message_to_langchain_message
pyris-app | ModuleNotFoundError: No module named 'common'
pyris-app exited with code 1
Please ensure that all imports are correct by either giving the full path or using relative paths. I'd reccommend the latter
@Hialus I have updated the problematic import statements. For general overhaul of import statements I will create an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, however the capability declarations are not sensible.
Also you did not adjust the SummaryPipeline.
Motivation
In the future, we want Pyris to use a capability based system. This PR enables the use of the existing capability system in existing pipelines. Other than that, MessageDTO and IrisMessage models are replaced by PyrisMessage class.
Summary by CodeRabbit
PyrisMessage
model andIrisMessageRole
enumeration for enhanced message handling.IrisMessage
toPyrisMessage
in multiple files for consistency.