-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Profile pictures in remaining places #214
Add Profile pictures in remaining places #214
Conversation
…dded dialog to missing ProfilePicture occurrences
Profile Picture shown in app settings ✅ All these are looking good!, I only notices a flickering happens when a message is sent. Screen.Recording.2024-12-13.at.16.57.32.mov |
Yep, I already investigated this bug and unfortunately it has a deeper root cause :( |
…rywhere # Conflicts: # feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes as described. I didn't experience any issues. Code lgtm!
Problem Description
In the previous PRs #111 and #163 Profile pictures has only been added to the main chat lists. But they are not displayed in other contexts.
Changes
Added profile picture in ...
Click on profile picture shows popup dialog
Misc
Steps for testing
For the following steps, you can confirm each time whether clicking on the profile picture shows the user dialog or not
Screenshots
Settings
Conversation Overview
Conversation Header
Members
Popup Dialog