Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Profile pictures in remaining places #214

Merged
merged 17 commits into from
Dec 19, 2024

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Dec 12, 2024

Problem Description

In the previous PRs #111 and #163 Profile pictures has only been added to the main chat lists. But they are not displayed in other contexts.

Changes

  • Added profile picture in ...

    • Conversation overview
    • Conversation header for DMs
    • User search (channel creation)
    • Conversation members
    • User settings screen
  • Click on profile picture shows popup dialog

  • Misc

    • Changed channel icons, so that only one icon get displayed per channel. Previously a single channel could have the icons for channel (hash), announcement, and archived. Now only the must important icon is displayed, similar to iOS.

Steps for testing

For the following steps, you can confirm each time whether clicking on the profile picture shows the user dialog or not

  • Go to the app settings
    • See that the profile picture is displayed here
  • Go back to conversation overview
    • For eg announcement channels (or archived ones), only a single icon is displayed
    • See that in the "Direct messages" section the profile pictures are displayed
  • Click on a non-DM chat
    • See that the channel icon is displayed in the title
    • Click on settings
    • See that the profile pictures are displayed in the members section
  • Navigate back and click on a DM chat
    • See the profile picture in the title
  • Navigate back and click the create channel floating action button
    • Search for a user
    • See that the profile picture is displayed

Screenshots

Settings
grafik

Conversation Overview
grafik

Conversation Header
grafik

Members
grafik

Popup Dialog
grafik

@FelberMartin FelberMartin linked an issue Dec 12, 2024 that may be closed by this pull request
@FelberMartin FelberMartin marked this pull request as ready for review December 12, 2024 18:55
@FelberMartin FelberMartin marked this pull request as draft December 12, 2024 18:56
@FelberMartin FelberMartin marked this pull request as ready for review December 13, 2024 09:32
@FelberMartin FelberMartin marked this pull request as draft December 13, 2024 09:56
…dded dialog to missing ProfilePicture occurrences
@FelberMartin FelberMartin marked this pull request as ready for review December 13, 2024 11:14
@FelberMartin FelberMartin self-assigned this Dec 13, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Dec 13, 2024
@FelberMartin FelberMartin requested a review from eylulnc December 13, 2024 13:05
@eylulnc
Copy link
Contributor

eylulnc commented Dec 13, 2024

Profile Picture shown in app settings ✅
Single icon displayed in conversation overview ✅
Profile picture displays in direct messages ✅
Profile picture displayed correctly in non-DM chat members ✅
Profile picture displays in DM chat title ✅
User search works as expected ✅

All these are looking good!, I only notices a flickering happens when a message is sent.

Screen.Recording.2024-12-13.at.16.57.32.mov

@FelberMartin
Copy link
Collaborator Author

All these are looking good!, I only notices a flickering happens when a message is sent.

Yep, I already investigated this bug and unfortunately it has a deeper root cause :(
Therefore I created a separate issue for this (see #203)

…rywhere

# Conflicts:
#	feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes as described. I didn't experience any issues. Code lgtm!

@FelberMartin FelberMartin merged commit daa76ad into develop Dec 19, 2024
5 checks passed
@FelberMartin FelberMartin deleted the feature/communication/profile-picture-everywhere branch December 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Pictures: Followup
3 participants