Feature: Add navigation animations
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationScreen.kt # feature/settings/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/settings/SettingsScreen.kt
julian-wls
reviewed
Dec 21, 2024
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/ui/SinglePageConversationBody.kt
Outdated
Show resolved
Hide resolved
julian-wls
approved these changes
Dec 21, 2024
eylulnc
approved these changes
Dec 22, 2024
FelberMartin
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Currently there are no animations when navigating the app. There should be smooth animations when navigating from one screen to another.
Changes
I have tested that adding the animations does not mess with the different layouts on both tablets and foldables.
Steps for testing
Navigate through all the app's screens and see that there are now animations when navigating