Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Adjust conversation overview alignments and styling #227

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Merge remote-tracking branch 'origin/bugfix/communication/change-chan…

c7a829f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Improvement: Adjust conversation overview alignments and styling #227

Merge remote-tracking branch 'origin/bugfix/communication/change-chan…
c7a829f
Select commit
Loading
Failed to load commit list.
GitHub Actions / JUnit Test Results succeeded Dec 22, 2024 in 0s

52 passed, 0 failed and 13 skipped

Tests passed successfully

Report Passed Failed Skipped Time
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationAnswerMessagesUITest.xml 5⚪ 4ms
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationMessagesUITest.xml 8⚪ 12ms
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceImplUpgradeLocalAnswerPostTest.xml 3✅ 34s
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestLiveCreation.xml 2✅ 545ms
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestUpdatePost.xml 1✅ 162ms
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.ConversationProfilePictureUiTest.xml 4✅ 21s
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.ConversationBottomSheetUiTest.xml 5✅ 5s
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.PostActionBarUITest.xml 7✅ 2s
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest.xml 8✅ 3s
test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest.xml 2✅ 504ms
test-outputs/login/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.login.login_moduleTest.xml 5✅ 59s
test-outputs/manage-conversations/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.manageconversations.manage_conversations_moduleTest.xml 7✅ 49s
test-outputs/push/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.push.PushNotificationReceiveTest.xml 4✅ 45s
test-outputs/shared/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.shared.db.MetisDaoTest.xml 4✅ 24s

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationAnswerMessagesUITest.xml

5 tests were completed in 4ms with 0 passed, 0 failed and 5 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationAnswerMessagesUITest 5⚪ 4ms

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationAnswerMessagesUITest

⚪ test GIVEN the post is resolved and one answer post is marked as resolving THEN the post is shown as resolved and this answer post is shown as resolving
⚪ test GIVEN post is not resolved WHEN resolving the post THEN the post is resolved with the third answer post
⚪ test GIVEN the post is not resolved and no answer post is resolving THEN the post is shown as not resolved and no answer post is shown as resolving
⚪ test GIVEN post is not resolved WHEN resolving the post THEN the post is resolved with the first answer post
⚪ test GIVEN post is resolved WHEN un-resolving the post THEN the post is un-resolved

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationMessagesUITest.xml

8 tests were completed in 12ms with 0 passed, 0 failed and 8 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationMessagesUITest 8⚪ 12ms

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ConversationMessagesUITest

⚪ test GIVEN the post is pinned THEN the post is shown as pinned
⚪ test GIVEN post is not pinned WHEN pinning the post THEN the correct post gets pinned
⚪ test GIVEN the post is not pinned in thread THEN the post is not shown as pinned in thread
⚪ test GIVEN post is pinned in thread WHEN unpinning the post THEN the correct post gets unpinned in thread
⚪ test GIVEN post is not pinned in thread WHEN pinning the post THEN the correct post gets pinned in thread
⚪ test GIVEN the post is pinned in thread THEN the post is shown as pinned in thread
⚪ test GIVEN the post is not pinned THEN the post is not shown as pinned
⚪ test GIVEN post is pinned WHEN unpinning the post THEN the correct post gets unpinned

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceImplUpgradeLocalAnswerPostTest.xml

3 tests were completed in 34s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceImplUpgradeLocalAnswerPostTest 3✅ 34s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceImplUpgradeLocalAnswerPostTest

✅ testInsertClientSidePost
✅ testUpgradeClientSideAnswerPost2
✅ testUpgradeClientSideAnswerPost

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestLiveCreation.xml

2 tests were completed in 545ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestLiveCreation 2✅ 545ms

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestLiveCreation

✅ testInsertLiveCreatedPostWithExistingPost
✅ testInsertLiveCreatedPost

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestUpdatePost.xml

1 tests were completed in 162ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestUpdatePost 1✅ 162ms

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.service.storage.impl.MetisStorageServiceTestUpdatePost

✅ testUpdatePostWithSameClientPostId

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.ConversationProfilePictureUiTest.xml

4 tests were completed in 21s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.ConversationProfilePictureUiTest 4✅ 21s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.ConversationProfilePictureUiTest

✅ test GIVEN a post with null for userName WHEN displaying the post THEN the unknown profile picture is shown
✅ test GIVEN a post without an authorImageUrl WHEN displaying the post THEN the users initials are shown
✅ test GIVEN a post with a profile picture WHEN clicking on it THEN the user profile dialog is shown
✅ test GIVEN a post with an authorImageUrl WHEN displaying the post THEN the profile picture is shown

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.ConversationBottomSheetUiTest.xml

5 tests were completed in 5s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.ConversationBottomSheetUiTest 5✅ 5s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.ConversationBottomSheetUiTest

✅ test GIVEN a post WHEN long pressing the post as non-moderator THEN delete option is not shown
✅ test GIVEN a user with moderation-rights WHEN long pressing the post THEN delete option is shown
✅ test GIVEN a user with moderation-rights WHEN long pressing the post THEN Edit action is not shown
✅ test GIVEN a post WHEN long pressing the post as the post author THEN delete option is shown
✅ test GIVEN a post WHEN long pressing the post THEN Edit action is shown

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.PostActionBarUITest.xml

7 tests were completed in 2s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.PostActionBarUITest 7✅ 2s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post.PostActionBarUITest

✅ test GIVEN a post WHEN navigating to the thread view without pin abilities THEN pin option is not shown
✅ test GIVEN a post WHEN navigating to the thread view as the post author THEN delete option is shown
✅ test GIVEN a post WHEN navigating to the thread view with pin abilities THEN pin option is shown
✅ test GIVEN a post WHEN navigating to the thread view THEN Edit action is shown
✅ test GIVEN a user with moderation-rights WHEN navigating to the thread view THEN Edit action is not shown
✅ test GIVEN a post WHEN navigating to the thread view as non-moderator THEN delete option is not shown
✅ test GIVEN a user with moderation-rights WHEN navigating to the thread view THEN delete option is shown

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest.xml

8 tests were completed in 3s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest 8✅ 3s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest

✅ test GIVEN the textField WHEN entering a non-tag character THEN the autoCompletion dialog is hidden
✅ test GIVEN the autoCompletion dialog WHEN removing the tag character @ THEN the autoCompletion dialog is hidden
✅ test GIVEN the autoCompletion dialog WHEN clicking an entry THEN the replacement is inserted into the textField and the dialog is hidden
✅ test GIVEN an empty reply textField WHEN doing nothing THEN the autoCompletion dialog is hidden
✅ test GIVEN an empty reply textField WHEN entering the tag character @ THEN a list of autoCompletionHints for users shows
✅ test GIVEN the textField WHEN entering a first and surname separated by a single whitespace THEN the dialog shows
✅ test GIVEN the autoCompletion has been performed WHEN entering the tag character again THEN the autoCompletion dialog shows again
✅ test GIVEN the textField WHEN entering a second whitespace THEN the dialog is hidden

✅ test-outputs/conversation/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest.xml

2 tests were completed in 504ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest 2✅ 504ms

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest

✅ test GIVEN the chat list containing three posts is shown WHEN the markdown text field is clicked THEN the keyboard is shown below the markdown text field
✅ test GIVEN the thread view is shown containing one post and three answer posts WHEN the markdown text field is clicked THEN the keyboard is shown below the markdown text field

✅ test-outputs/login/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.login.login_moduleTest.xml

5 tests were completed in 59s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.login.login_moduleTest 5✅ 59s

✅ de.tum.informatics.www1.artemis.native_app.feature.login.login_moduleTest

✅ the loginModule initializes RegisterViewModel without errors
✅ the loginModule initializes Saml2LoginViewModel without errors
✅ the loginModule initializes CustomInstanceSelectionViewModel without errors
✅ the loginModule initializes LoginViewModel without errors
✅ the loginModule initializes AccountViewModel without errors

✅ test-outputs/manage-conversations/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.manageconversations.manage_conversations_moduleTest.xml

7 tests were completed in 49s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.manageconversations.manage_conversations_moduleTest 7✅ 49s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.manageconversations.manage_conversations_moduleTest

✅ the manage_conversations_module initializes ConversationOverviewViewModel without errors
✅ the manage_conversations_module initializes ConversationMembersViewModel without errors
✅ the manage_conversations_module initializes CreatePersonalConversationViewModel without errors
✅ the manage_conversations_module initializes BrowseChannelsViewModel without errors
✅ the manage_conversations_module initializes CreateChannelViewModel without errors
✅ the manage_conversations_module initializes ConversationAddMembersViewModel without errors
✅ the manage_conversations_module initializes ConversationSettingsViewModel without errors

✅ test-outputs/push/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.push.PushNotificationReceiveTest.xml

4 tests were completed in 45s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.push.PushNotificationReceiveTest 4✅ 45s

✅ de.tum.informatics.www1.artemis.native_app.feature.push.PushNotificationReceiveTest

✅ should forward notification with valid version
✅ should discard notification with non-existing version
✅ should discard gibberish notification
✅ should discard notification with non-matching version

✅ test-outputs/shared/testProductionTumReleaseUnitTest/TEST-de.tum.informatics.www1.artemis.native_app.feature.metis.shared.db.MetisDaoTest.xml

4 tests were completed in 24s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.informatics.www1.artemis.native_app.feature.metis.shared.db.MetisDaoTest 4✅ 24s

✅ de.tum.informatics.www1.artemis.native_app.feature.metis.shared.db.MetisDaoTest

✅ testAddPost
✅ testDeletePostWithReaction
✅ testAddPostWithReaction
✅ testDeletePost