Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Koin upgrade followup #243

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Chore: Koin upgrade followup #243

wants to merge 6 commits into from

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

There were still a few follow-ups after #135, these are tackled here.

Changes

  • Using new koin verify() method to verify module initialization
  • Removing now no longer needed workaround to use koin in tests (LocalKoinScope, LocalKoinApplication)

Steps for testing

  • See that all tests still pass

@FelberMartin FelberMartin self-assigned this Dec 20, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-wls julian-wls Awaiting requested review from julian-wls

Assignees

@FelberMartin FelberMartin

Labels
ready for review This PR can be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FelberMartin