`Feature`: Save messages for later #259

FelberMartin · 2024-12-30T10:40:42Z

Problem Description

The Android app did not yet support the "Saved Messages" feature recently introduced in the webapp. This PR introduces the related use cases.

Changes

Created new network service SavedPostService
- Extended BasePost with new SavedPost
Created actions to mark/unmark a post as saved
Created new section in the ConversationOverview for Saved messages
Introduced new SavedPostsScreen for displaying the list of saved posts
- Implemented design heavily inspired by the webapp
- Pressing on a saved post navigates the user to the post's thread
- Long pressing on a post shows a BottomSheet with action to change the status
- Introduced MetisModificationTaskHandler for sharing MetisModification functionality
- Changed core of PostItem to be re-used by SavedPostItem
Created tests

Steps for testing

Go to any chat
- Long press on a post to show to action bottomSheet and save it for later -> Post is highlighted in blue and a "Saved for later" indicator is shown
- Click on post to show it in the thread view
- Here you can also change the isSaved via the ActionTabBar
Go back to the conversationOverview
- Notice the new "Saved messages" section
- Click on "In progress" -> saved messages are shown
- Click on the saved post -> navigate to the post's thread
- Navigate back
- Change the savedPostStatus of the post via the action bottomSheet

Screenshots

20250110-1626-45.7874155.mp4

Known Issues

Navigating back after clicking on a saved message, currently does not take the user back to the SavedPostScreen -> tackled in Bugfix: Chats not loading on tablet layout #280
When toggling the isSaved state in the ThreadUi via the ActionTabBar, the action icons flicker -> Reload leads to flickering in UI #268
SavedMessages does not yet support the split screen layout with the conversation overview on the left (eg on tablet) -> Followup: Move SavedPostsScreen to new TwoColumn layout #288
Spamming the savePost button in the Threads ActionTabBar results in multiple saved posts being created for that post -> Save messages follow-up: Bug when spaming save post button #307

Further Input needed : Sometimes I could observe that when navigating to a post via the SavedPostScreen that the thread failed to load. Even after multiple retries the thread only very shortly showed up but then disappeared again. I could not consistently reproduce this issue, so if you find a scenario where this occurs regularly, please let me know

…returned by getSavedPosts API

julian-wls

Looks really nice and works as expected.

Regarding the flickering of the PostActionBar: I also noticed that after the reload the isSaved Button is sometimes not correctly updated, but I wa not able to constantly reproduce this.
I also noticed some padding issues, see below:

...de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/SavedPostsScreen.kt

FelberMartin · 2025-01-16T14:20:26Z

I added the paddings as requested. While debugging the padding I found that there are some issues with the padding propagated by the CourseScreenUI, but I will create a follow up PR about this, this PR is already way to huge :D

Regarding the inconsistent icon in the PostActionBar I was not able to reproduce it. In case you find out how, let me know :)

…ater

eylulnc

Looking really nice! One point for discussion: what do you think about placing the button in 'In Progress' inside the text area (I dont know if its possible though😅), aligned to the right, or using icon buttons like on the web? Just a thought to improve UI but not a must 😅

FelberMartin · 2025-01-17T07:34:43Z

One point for discussion: what do you think about placing the button in 'In Progress' inside the text area (I dont know if its possible though😅), aligned to the right, or using icon buttons like on the web? Just a thought to improve UI but not a must 😅

It is somehow possible, we can not directly put the button inside the textarea, but next to or below it. That's what it would look like with the button inside the card:

Compared to previous:

Let me know what you think @eylulnc :D

eylulnc · 2025-01-18T17:55:54Z

One point for discussion: what do you think about placing the button in 'In Progress' inside the text area (I dont know if its possible though😅), aligned to the right, or using icon buttons like on the web? Just a thought to improve UI but not a must 😅

It is somehow possible, we can not directly put the button inside the textarea, but next to or below it. That's what it would look like with the button inside the card:

Compared to previous:

Let me know what you think @eylulnc :D

I really like the new one, I think it looks more appealing 😊

julian-wls

Code lgtm now,
I agree with @eylulnc. The new design with the button inside the list item looks better.
I also tested the changes once again in detail and couldn't find any issues. This branch can be merged imo.

…ion/save-messages-for-later # Conflicts: # app/src/main/java/de/tum/informatics/www1/artemis/native_app/android/db/AppDatabase.kt # feature/core-modules-test/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/coremodulestest/AppModuleTest.kt # feature/course-view/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/courseview/ui/course_overview/CourseUiScreen.kt # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/BaseChatUITest.kt # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationProfilePictureUiTest.kt # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/ConversationBottomSheetUiTest.kt # feature/metis/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/ConversationConfiguration.kt # feature/metis/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/ui/SinglePageConversationBody.kt # feature/metis/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/communication_moduleTest.kt

…ater # Conflicts: # core/ui/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/Spacings.kt # feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt # feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/BaseChatUITest.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/create_personal_conversation/PotentialRecipientsUi.kt

FelberMartin added 10 commits December 27, 2024 20:54

Use tum artemis server url as default for unrestricted build flavor

00f6c1d

Adapt ServerConfigurationService to use default implementations

e09dfd0

Adapt code to no longer rely on InstanceSelection

785b68f

Implemented new service

96c95c7

Displaying saved message categories

fbef9c2

Enabled navigation to saved posts

d9b3436

Extended service to call post status apis

beef456

Pass onSavePost down in UI to ViewModel

69d3f3a

Update data objects to include isSaved

19df8fd

Minor fixes

097ce4d

FelberMartin added the database changes This PR includes database changes and should be treated with extra care when merging label Dec 30, 2024

FelberMartin self-assigned this Dec 30, 2024

Adapted tests; added PostActionBarUITest for savePost

1edb2a7

FelberMartin mentioned this pull request Dec 30, 2024

Simplify ConversationOverview code for sections #260

Open

FelberMartin added 4 commits December 30, 2024 14:12

Added UI tests

7343037

Fixed test

1d89bd6

Moving SavedPostService to conversation sub module

67f8965

WIP Add tests; noticed deserialization issue

a4fc896

FelberMartin changed the base branch from develop to chore/set-tum-artemis-server-as-default December 31, 2024 11:03

FelberMartin added 11 commits December 31, 2024 16:04

Created new dataClass SavedPost to deal with different serialization …

f8f748f

…returned by getSavedPosts API

Fixing tests; WIP 3rd test still failing

dd62735

Fix changeSavePostStatus call

ab28f66

Created drafts for screens and SavedPostItem

e975715

Navigation to SavedPostsScreen

1e06dab

Added bottomSheet to change SavedPostStatus

bdbd509

Fix reload stuttering

bd885cb

Show failure dialog

399a082

Add button in IN_PROGRESS

911529b

Fix key to work with standalone and answer posts

83197f0

Added animations

4bd47c0

Use spacings

91fe82a

julian-wls requested changes Jan 16, 2025

View reviewed changes

Fixed paddings

5194307

FelberMartin requested a review from julian-wls January 16, 2025 14:20

Merge branch 'develop' into feature/communication/save-messages-for-l…

8630711

…ater

FelberMartin mentioned this pull request Jan 16, 2025

Save messages follow-up: Bug when spaming save post button #307

Open

Fix spamming save button bug

720835f

eylulnc approved these changes Jan 16, 2025

View reviewed changes

Fix display of non-distinct post items

f4a4d9d

Increase db version

94697dc

julian-wls approved these changes Jan 22, 2025

View reviewed changes

FelberMartin added 8 commits January 22, 2025 18:36

Fix crash when saving answer post

4935749

Move completeButton into card

b09308e

Fix CompleteButton padding

6dcfddb

Fix display of duplicated savedPosts created by bug

535c7f0

Fix navigation

cd23dd1

Fix test after merge

cc79f22

Display images in savedPosts

db59e84

FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Jan 22, 2025

FelberMartin added 4 commits January 23, 2025 08:19

Fix merge issues

9e1225b

Fix spacings

d9b65dc

Ignore flaky test

99e7d5c

FelberMartin merged commit 1ab77bb into develop Jan 23, 2025
5 checks passed

FelberMartin deleted the feature/communication/save-messages-for-later branch January 23, 2025 09:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Feature`: Save messages for later #259

`Feature`: Save messages for later #259

FelberMartin commented Dec 30, 2024 •

edited

Loading

julian-wls left a comment

FelberMartin commented Jan 16, 2025

eylulnc left a comment •

edited

Loading

FelberMartin commented Jan 17, 2025

eylulnc commented Jan 18, 2025

julian-wls left a comment

Feature: Save messages for later #259

Feature: Save messages for later #259

Conversation

FelberMartin commented Dec 30, 2024 • edited Loading

Problem Description

Changes

Steps for testing

Screenshots

Known Issues

julian-wls left a comment

Choose a reason for hiding this comment

FelberMartin commented Jan 16, 2025

eylulnc left a comment • edited Loading

Choose a reason for hiding this comment

FelberMartin commented Jan 17, 2025

eylulnc commented Jan 18, 2025

julian-wls left a comment

Choose a reason for hiding this comment

`Feature`: Save messages for later #259

`Feature`: Save messages for later #259

FelberMartin commented Dec 30, 2024 •

edited

Loading

eylulnc left a comment •

edited

Loading