Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Replace three column with two column conversation layout for large screens #279

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

On tablets the layout with the ConversationOverview, ChatList and ThreadUI all displayed at once is quite packed and results in many UI elements being displayed incorrectly, due to the little space available. Additionally the iOS tablet version also does not support the 3-column layout. So by changing to a two column layout we also align the mobile experiences.

Changes

Changed the ConversationScreen to only show two columns at most.

Steps for testing

On tablet or foldable:

  • Go to ConversationOverview
  • Open Chat -> Chat is displayed on the right
  • Navigate to thread -> ConversationOverview on the left + Thread on the right is displayed.

On smartphone:

  • Everthing works as before

Screenshots

20250109-1039-53.7031318.mp4

@FelberMartin FelberMartin self-assigned this Jan 9, 2025
@FelberMartin FelberMartin changed the title Chore/two column conversation layout Chore: Replace three column with two column conversation layout for large screens Jan 9, 2025
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on tablet, works as expected and looks a lot better. Thanks for taking care of this :)
Code lgtm!

@FelberMartin FelberMartin added the ready to merge This PR can be merged label Jan 10, 2025
@FelberMartin FelberMartin merged commit a56ead7 into develop Jan 10, 2025
5 checks passed
@FelberMartin FelberMartin deleted the chore/two-column-conversation-layout branch January 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants