-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement
: Redesign exercise screen & adjustments
#295
Conversation
…Screen to pull to refresh
…w the latest graded result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality and both works and looks awesome. Especially the height adjusted webview improves usability by a lot!
Don't be frightened by the large number of code comments, most of them are just minor code style suggestions and refactoring oppportunities I found :)
...src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/compose/ArtemisWebView.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseActionButtons.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseCategoryChips.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseCategoryChips.kt
Show resolved
Hide resolved
.../main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseListItem.kt
Show resolved
Hide resolved
...nformatics/www1/artemis/native_app/feature/exerciseview/home/overview/ExerciseOverviewTab.kt
Outdated
Show resolved
Hide resolved
...emis/native_app/feature/metis/manageconversations/service/network/impl/ChannelServiceImpl.kt
Outdated
Show resolved
Hide resolved
...nformatics/www1/artemis/native_app/feature/exerciseview/home/overview/ExerciseOverviewTab.kt
Outdated
Show resolved
Hide resolved
...nformatics/www1/artemis/native_app/feature/exerciseview/home/overview/ExerciseOverviewTab.kt
Outdated
Show resolved
Hide resolved
...tum/informatics/www1/artemis/native_app/feature/exerciseview/home/ExerciseScreenTopAppBar.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! 😊 Test cases ✅, and Martin's annotations already address everything. Once his requests are applied, it’s good to go for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now!
Problem Description
Currently, the exercise view is quite unstructured compared to the iOS app. Points and build information are not as visible, and when holding the phone in landscape mode, scrolling through the web view becomes nearly impossible.
Changes
This PR introduces the following changes:
Steps for testing
Screenshots
Known issues
The changes have been verified to work on tablets and foldables.