-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Recent Section
#321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with exam, lecture, and exercise, works as described.
While testing, I noticed that we can currently not straight-away tell which category (exam, lecture, exercise) the chat in the recents section belong to. We should not remove the conversation-prefix here imo
.../feature/metis/manageconversations/ui/conversation/overview/ConversationOverviewViewModel.kt
Outdated
Show resolved
Hide resolved
...artemis/native_app/feature/metis/manageconversations/overview/ConversationOverviewE2eTest.kt
Outdated
Show resolved
Hide resolved
...matics/www1/artemis/native_app/feature/metis/shared/content/dto/conversation/Conversation.kt
Outdated
Show resolved
Hide resolved
.../feature/metis/manageconversations/ui/conversation/overview/ConversationOverviewViewModel.kt
Outdated
Show resolved
Hide resolved
You are right, I have updated the prefix |
…into feature/communication/recent-section # Conflicts: # feature/course-view/src/debug/kotlin/de/tum/informatics/www1/artemis/native_app/feature/courseview/MessagingScreenshots.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/service/storage/ConversationPreferenceService.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/service/storage/impl/ConversationPreferenceStorageServiceImpl.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/overview/ConversationList.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/overview/ConversationOverviewViewModel.kt # feature/metis/manage-conversations/src/main/res/values/conversation_overview_strings.xml
@FelberMartin @julian-wls should I remove the exam part as we speak and work it on after we decide to add the exam module. Or we I leave it as it is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now
For me it would be fine to leave it as is for now, but do however you see fit, I dont have a strong opinion on it :D |
Just to align with iOS I will remove it and in the future we can add it in a more meaningful way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested it. Works as expected.
Code lgtm.
Problem Description
The Recent section was missing in the conversation list, and no dedicated feature existed to display conversations based on their temporal relevance. This created inconsistencies with the iOS and Web implementations, which already have a Recent section for filtering conversations within a defined time range (e.g., for exercises, lectures, and exams).
Changes
New Recent Section Implementation:
- Exams: Include conversations created within 10 days before or after the current date.Steps for testing
- Exams with creation dates within 10 days before or after the current date.Exams:Verify that exams with creation dates within the 10-day range are displayed.Check that exams outside the range are not included.Screenshots