Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Release 1.4.0 #198

Merged
merged 10 commits into from
Oct 28, 2024
Merged

General: Release 1.4.0 #198

merged 10 commits into from
Oct 28, 2024

Conversation

anian03
Copy link
Member

@anian03 anian03 commented Oct 26, 2024

New

  • Number of channel members shown in title bar
  • Support for iOS 18 with Dark Mode app icon and floating tab bar on iPadOS 18
  • Easier formatting of text when composing messages
  • Profile Pictures in channel member list
  • FAQ Tab
  • Support for displaying images in chats

Fixed

  • Inconsistent titles for exercise and lecture count
  • Formatting issues in Conversation Info when names contained non ascii-characters
  • Message actions may have offset touch targets
  • Message Reaction View may disappear delayed

Testing

How to install

  1. Join Artemis TestFlight Beta: testflight.apple.com/join/canwoVCk
  2. Download & Install Latest Build of Version 1.4

What to test

  • Verify that all described bugs have been fixed
  • Ensure that formatting text works
  • Check whether profile pictures are shown in channel member list and that the correct actions are shown when tapping on a user
  • Ensure that the buttons when long pressing a message all work
  • Make sure sending and replying to messages etc still works

You can use a test server by entering its url on the login screen under "Select university">"Custom instance".

* Display number of members for channels and groups

* Increment version number
* Set deployment target to iOS 18

* Add dark mode app icon
* Fix floating tab bar overlapping navigation bar on iPadOS 18

* Remove unused code

* Hide new tab bar on large iPhones in landscape mode
* Use TextSelection for text formatting

* Insert exercise/lecture mentions at cursor point

* Update channel/member buttons to insert at current cursor

* Increase icon size of toolbar
* Add missing automatic grammar agreement for lecture list

* Remove unused localization
…ist (#191)

* Add profile pictures to channel member list

* Integrate channel info sheet with profile info sheet
* Add FaqService

* Add FAQ

* Update package versions

* Add localization for Read more

* Show only accepted faqs

* Use question mark icon for no faqs available
* Fix crash related to TextSelection

* Update core modules
@anian03 anian03 self-assigned this Oct 26, 2024
@anian03 anian03 marked this pull request as ready for review October 26, 2024 23:26
Copy link

@JanaNF JanaNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manual on a iPhone 13 mini. Worked but long question were not fully displayed

Copy link

@PaRangger PaRangger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍🏼

@anian03 anian03 merged commit 675ac01 into main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants