Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /bin/sh instead of /bin/bash #35

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Use /bin/sh instead of /bin/bash #35

merged 1 commit into from
Jan 9, 2024

Conversation

robertjndw
Copy link
Member

No description provided.

@robertjndw robertjndw added bug Something isn't working component: Docker Scheduler labels Dec 8, 2023
@robertjndw robertjndw requested a review from Mtze December 8, 2023 13:21
@robertjndw robertjndw self-assigned this Dec 8, 2023
@Mtze
Copy link
Member

Mtze commented Dec 8, 2023

Maybe we should make this configurable in the Hades Options. What do you think?

@robertjndw
Copy link
Member Author

Not sure about that. I mean it solely depends on the request image. The only thing we can allow to set is a sane default, but we still have a problem if it does not exists in the image 🤔

@Mtze Mtze merged commit 3ebf3cd into main Jan 9, 2024
3 checks passed
@Mtze Mtze deleted the use-generic-shell-instead-of-bash branch January 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mtze Mtze Mtze approved these changes

Assignees

@robertjndw robertjndw

Labels
bug Something isn't working component: Docker Scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertjndw @Mtze