Remove thesis track and fix imports #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the change - I'd like to postpone the merge of this until after the intro course since this is a pretty hefty change :) |
bgeisb
requested changes
Oct 2, 2024
There was a problem hiding this comment.
The route /management/mailing should now only have permission={[Permission.PM]}.
There was a problem hiding this comment.
in the route /management/mailing is an array of who as access and it is an 'OR' array. So persons with either PM or Chair_Member have access, which is fine in my opinion.
I think what you mean are the access rights to the mail templates, which are set in the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cleanup PR, which removes the Thesis Track completely from this project, as ThesisTrack has its own repo and every thesis related URL request is already redirected.
Type of change
How Has This Been Tested?
I tested the database migration on my local machine. Further, I made sure to only remove dead code, and to really remove everything which is solely Thesis Track related
CAREFUL: This PR includes a database migration, which will delete all Thesis related database tables from the prompt database. Please review first, if this database migration is wanted/correct and if the data in these database tables is not needed any more.