-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic app shell for the authenticated area #131
Merged
fabian-emilius
merged 46 commits into
main
from
82-implement-basic-app-shell-for-the-authenticated-area
Jul 29, 2024
Merged
Implement basic app shell for the authenticated area #131
fabian-emilius
merged 46 commits into
main
from
82-implement-basic-app-shell-for-the-authenticated-area
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:ls1intum/thesis-track into feature/thesis-chart-mockup # Conflicts: # .gitignore # client/eslint.config.mjs # client/package.json # client/src/App.tsx # client/src/pages/ThesisManagementConsole/components/ThesisApplicationsDatatable/ThesisApplicationsDatatable.tsx # client/webpack.config.ts # client/yarn.lock
…ment-basic-app-shell-for-the-authenticated-area # Conflicts: # client/src/interface/application.ts # client/webpack.config.ts
…e date is too long
robertjndw
approved these changes
Jul 27, 2024
fabian-emilius
deleted the
82-implement-basic-app-shell-for-the-authenticated-area
branch
July 29, 2024 11:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large refactoring PR but needed to set the foundations for the planned features. The old functionality to submit an application and to review application still exists and is working
I am sorry that this PR is so large. This should not be required going forward. Dont be intimidated by the amount of files. Most files are just containing an empty component because I already implemented a component for every page that will exist.
Testing URLs:
Screenshot of new AppShell + Old review application logic
Changes
Deployment Changes
REACT_APP_SERVER_HOST
toAPI_SERVER_HOST
REACT_APP_KEYCLOAK_HOST
toKEYCLOAK_HOST
REACT_APP_KEYCLOAK_REALM_NAME
toKEYCLOAK_REALM_NAME
KEYCLOAK_CLIENT_ID
to configure keycloak client id as environmentthesis-track-app
. This client should be public and not authenticated. To access the application management, the newadmin
resource role is needed (Create roleadmin
in newly created client or use existing thesis-track-client keycloak client). I added an example keycloak realm export to the repository but probably not neededThis new configuration should allow to configure a seperate client for the dev / staging deployment which makes it easier to test features