Merge pull request #268 from ls1intum/code-cleanup

Code cleanup
ls1intum · Sep 16, 2024 · 78d3030 · 78d3030
2 parents 7654552 + f741242
commit 78d3030
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/client/src/pages/ThesisOverviewPage/ThesisOverviewPage.tsx b/client/src/pages/ThesisOverviewPage/ThesisOverviewPage.tsx
@@ -12,7 +12,7 @@ import { Plus } from 'phosphor-react'
 import { useHasGroupAccess } from '../../hooks/authentication'
 
 const ThesisOverviewPage = () => {
-  usePageTitle('Theses Overview')
+  usePageTitle('Theses')
 
   const [openCreateThesisModal, setOpenCreateThesisModal] = useState(false)
 
@@ -39,7 +39,7 @@ const ThesisOverviewPage = () => {
         }
       >
         <Group>
-          <Title mb='md'>Theses Overview</Title>
+          <Title mb='md'>Theses</Title>
           {managementAccess && (
             <Button
               ml='auto'

diff --git a/...nts/ThesisWritingSection/components/ReplacePresentationModal/ReplacePresentationModal.tsx b/...nts/ThesisWritingSection/components/ReplacePresentationModal/ReplacePresentationModal.tsx
@@ -59,10 +59,6 @@ const ReplacePresentationModal = (props: IReplacePresentationModalProps) => {
         if (!value) {
           return 'Date is required'
         }
-
-        if (value.getTime() <= Date.now()) {
-          return 'Date must be in the future'
-        }
       },
     },
   })

diff --git a/server/src/main/java/thesistrack/ls1/service/MailingService.java b/server/src/main/java/thesistrack/ls1/service/MailingService.java
@@ -34,7 +34,11 @@ public MailingService(
     }
 
     public void sendApplicationCreatedEmail(Application application) {
-        MailBuilder chairMailBuilder = new MailBuilder(config, "New Thesis Application", "application-created-chair");
+        MailBuilder chairMailBuilder = new MailBuilder(
+                config,
+                "New Thesis Application ({{application.user.firstName}} {{application.user.lastName}})",
+                "application-created-chair"
+        );
         chairMailBuilder
                 .sendToChairMembers()
                 .addStoredAttachment(application.getUser().getCvFilename(), getUserFilename(application.getUser(), "cv", application.getUser().getCvFilename()))