Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather then try and go through the Angular update process, across so many major versions, I started a new Angular8 project created with the cli and copied your code into it Class by Class. Applied fixes to recent TypeScript and Angular8 changes like directive attributes. Also changed some minor stuff to reflect recent Angular best practices, like direct imports instead of barrel indexes etc. Fixed some items that TSLint and IntelliJ were complaining about (like selectors). It's essentially your code in a new ng8 project.