Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.
Note: Remove this section if this PR is NOT a breaking change.
Proposed change*
Hey,
I recently wanted to change the mapping for one of my lights. Unfortunately, that currently requires me to change the lights.yaml and adjusting/merging it every time I want to update the blueprint. So I did what any sane person would do and spent hours creating a prototype :D
How it works:
ahb_custom_mappings
ikea_e1524_1.yaml
ikea_e1524_1
as the Controller Mappingso the file structure for my branch would look something like this:
blueprints/automation/botastic/ahb_tmp/
I did not update the documentation yet, because I wanted to first see if you'd be interested in this feature.
Also the
ikea_e1524_1.yaml
file is currently listed as a blueprint with an error.So far, I have not been able to fix this. Personally, it doesn't bother me, but it might be irritating to others.This could be fixed by moving theahb_custom_mappings
to a different location, e.g.blueprints/ahb_custom_mappings
, and adjusting the include path accordingly (../../ahb_custom_mappings
). Not sure whether this would be against any convention.Cheers
Checklist*
npm run format
before submitting my Pull Request.