Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre-commit #96

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix pre-commit #96

wants to merge 1 commit into from

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Nov 4, 2021

  • unused imports
  • return after else
  • remove unreachable code

Still to fix: _parse_bands uses new interface only available in cp2k
develop branch

 * unused imports
 * return after else
 * remove unreachable code

Still to fix: _parse_bands uses new interface only available in cp2k
develop branch

return self.ctx.current_p_index < len(self.ctx.pressures)
Copy link
Member Author

@ltalirz ltalirz Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieleongari This line was not reachable and I'm therefore removing it.
Let me know if that was unexpected

@ltalirz
Copy link
Member Author

ltalirz commented Nov 4, 2021

Furthermore, there is one instance of _parse_bands that takes a cp2k version, which is only available in the aiida-cp2k develop branch.

@danieleongari is it safe to use the latest version of the develop branch from aiida-cp2k (in which case I will try to get a new release of aiida-cp2k going) or are there other changes that one needs to watch out for?

@codecov-commenter
Copy link

Codecov Report

Merging #96 (65c5f95) into develop (0999cce) will increase coverage by 0.02%.
The diff coverage is 3.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    70.61%   70.64%   +0.02%     
===========================================
  Files           34       34              
  Lines         2808     2807       -1     
===========================================
  Hits          1983     1983              
+ Misses         825      824       -1     
Impacted Files Coverage Δ
aiida_lsmo/workchains/isotherm_accurate.py 18.62% <3.57%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0999cce...65c5f95. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants