API for light intensity and color at night and day #14091

sfence · 2023-12-11T04:30:08Z

Add compact, short information about your PR for easier understanding:

Allows games to change sun color, intensity, and night's darkness.
It changed get_sunlight_color function, so no constants are used for sun color calculation, but configurable parameters.
This can be useful with mods that control moon phases and weather. It also can be useful in space games.
With this, heavy cloudy nights can be darkness than normal nights, etc.

To do

This PR is Ready for Review.

How to test

Run game devtest and run command set_light_intensity from lighting mod.

Screen.Recording.2024-01-02.at.17.47.51_480.mov

builtin/game/features.lua

games/devtest/mods/lighting/set_lightIntensity.lua

games/devtest/mods/lighting/set_lighting.lua

src/lighting.h

Zughy

only went through the DOCS. It'd be also nice having some pictures or a small video

doc/lua_api.md

sfence · 2024-01-02T17:06:45Z

@appgurueu @Zughy Fixes, feedback applied, rebased, and a small video added (to PR itself).

sfence · 2024-02-03T22:19:15Z

Rebased, merged to one commit, and cleaned Lua code

src/script/lua_api/l_object.cpp

Andrey2470T · 2024-06-28T17:11:04Z

I've made some testing of this feature. I assume it actually should depend now on #14789 as it repairs generally applying any colorful light values to the common vertex light color and this PR is not an exception also.

At the set single-channel color offsets the devtest player model gets fully dark. It happens on adjusting the red and blue channels:

The particles are not affected by the sunlight color at all with any combinations of the offsets and coefficients:

The color of the nodes going with such paramtype2 as colorfacedir (and I'm sure also other its colorized analogues) randomly diverges with the actual set sunlight color. This much possibly happens of that issue (wrong mixing of the different light colors together with the hardware one):

doc/lua_api.md

Andrey2470T · 2024-06-28T17:32:22Z

src/lighting.h

+ * sunlight->b = colorOffset_rgb.Z+colorRatioCoef_rgb.Z*daynight_ratio;
+ *
+ */
+struct LightIntensity


Should be renamed to SkyLight for the same reason mentioned above.

Andrey2470T · 2024-06-28T17:42:27Z

src/script/lua_api/l_object.cpp

+		if (lua_istable(L, -1)) {
+			lua_getfield(L, 3, "color_offset");
+			if (lua_istable(L, -1)) {
+				lighting.lightIntensity.colorOffset_rgb.X = getfloatfield_default(L, -1, "r", lighting.lightIntensity.colorOffset_rgb.X);


Create a some reference to the structure like LightIntensity &sky_light = lighting.lightIntensity to avoid writing overly long lines. Also, I think it is worth to remove _rgb suffix since it is pretty clear this is RGB format by judging the storing only 3 float values (v3f).

Andrey2470T · 2024-06-28T17:46:02Z

src/network/clientpackethandler.cpp

@@ -1815,4 +1815,12 @@ void Client::handleCommand_SetLighting(NetworkPacket *pkt)
 	}
 	if (pkt->getRemainingBytes() >= 4)
 		*pkt >> lighting.volumetric_light_strength;
+	if (pkt->getRemainingBytes() >= 24) {


I think it is worth to change the check for the bytes availability in the packet doing it similar with https://github.com/minetest/minetest/pull/14343/files#diff-592338f1bfb0275512da218625ce67e993b91984c175f70fe376825ab4e0aad2R1804

This is the normally used style.
I will change it in the rebase after PR #14343 is merged.

nerzhul · 2024-06-28T18:39:14Z

src/client/mapblock_mesh.cpp

@@ -30,6 +30,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "util/directiontables.h"
 #include "client/meshgen/collector.h"
 #include "client/renderingengine.h"
+#include "client/localplayer.h"


why localplayer is included here ? we should not have player inclusion on mapblock_mesh, which is close to render and has nothing to do with player session/object

Because the light setting is stored in the local player.

Andrey2470T · 2024-06-29T19:35:44Z

If the shaders are disabled, the new sunlight color on the mapblocks meshes should be appeared immediately after updating it in LocalPlayer. You could keep some flag signalizing about that somewhere in the ClientMap and then call MapblockMesh->animate() on all visible mapblock meshes. Because currently this circumstance leads to the following artifacts:

sfence · 2024-07-01T07:03:42Z

At the set single-channel color offsets the devtest player model gets fully dark. It happens on adjusting the red and blue channels:

The particles are not affected by the sunlight color at all with any combinations of the offsets and coefficients:

The color of the nodes going with such paramtype2 as colorfacedir (and I'm sure also other its colorized analogues) randomly diverges with the actual set sunlight color. This much possibly happens of that issue (wrong mixing of the different light colors together with the hardware one):

No affected particles are a bug. I will check it.

When texture without red color is shown as black in the light which does not include the red part, it is not a bug.
You cannot expect that a surface that can reflect only red light, will reflect green or blue light.

This PR should affect only the color of sunlight, not the color of light from artificial light sources.
You cannot expect that the pure red texture will reflect pure green light.

sfence · 2024-11-03T18:56:30Z

Rebased, sky color is applied also to particles.

wsor4035 added @ Script API @ Client rendering labels Dec 11, 2023

sfan5 changed the title ~~Light intensity and color at night and day~~ API for light intensity and color at night and day Dec 12, 2023

Zughy added Feature ✨ PRs that add or enhance a feature Roadmap The change matches an item on the current roadmap labels Dec 12, 2023

sfence force-pushed the sfence_lightIntensity branch from a0a30f4 to cbcfa1f Compare December 22, 2023 03:21

appgurueu reviewed Dec 28, 2023

View reviewed changes

Zughy reviewed Dec 29, 2023

View reviewed changes

doc/lua_api.md Outdated Show resolved Hide resolved

doc/lua_api.md Outdated Show resolved Hide resolved

doc/lua_api.md Outdated Show resolved Hide resolved

sfence force-pushed the sfence_lightIntensity branch from 78d8b63 to ecd7eb7 Compare January 2, 2024 16:59

sfence force-pushed the sfence_lightIntensity branch from 423525e to 1de2312 Compare January 22, 2024 15:38

sfence force-pushed the sfence_lightIntensity branch from 1de2312 to 5a9c097 Compare February 3, 2024 22:11

sfence force-pushed the sfence_lightIntensity branch 2 times, most recently from 40144a3 to 4b3ed11 Compare February 23, 2024 18:46

sfence force-pushed the sfence_lightIntensity branch from 4b3ed11 to 60d1927 Compare March 25, 2024 04:43

sfan5 reviewed Mar 31, 2024

View reviewed changes

src/script/lua_api/l_object.cpp Outdated Show resolved Hide resolved

sfan5 mentioned this pull request Mar 31, 2024

Ambient light and server control for it #14343

Closed

GefullteTaubenbrust2 mentioned this pull request Apr 1, 2024

Various visual effects #14508

Closed

Andrey2470T mentioned this pull request Jun 27, 2024

Use a new two-color vertex type for mapblock meshes #14789

Closed

2 tasks

Andrey2470T reviewed Jun 28, 2024

View reviewed changes

doc/lua_api.md Outdated Show resolved Hide resolved

Andrey2470T reviewed Jun 28, 2024

View reviewed changes

nerzhul reviewed Jun 28, 2024

View reviewed changes

sfence force-pushed the sfence_lightIntensity branch from 60d1927 to e4c4c8a Compare August 6, 2024 15:13

sfence force-pushed the sfence_lightIntensity branch from e4c4c8a to b03c4b0 Compare October 2, 2024 14:21

Andrey2470T mentioned this pull request Oct 6, 2024

Decouple Ambient Occlusion from Shadows #15176

Open

Add support for change sky light color in night and day.

a4bb71d

sfence force-pushed the sfence_lightIntensity branch from 09a54f8 to a4bb71d Compare November 3, 2024 18:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API for light intensity and color at night and day #14091

API for light intensity and color at night and day #14091

sfence commented Dec 11, 2023 •

edited

Loading

Zughy left a comment •

edited

Loading

sfence commented Jan 2, 2024 •

edited

Loading

sfence commented Feb 3, 2024 •

edited

Loading

Andrey2470T commented Jun 28, 2024 •

edited

Loading

Andrey2470T Jun 28, 2024

Andrey2470T Jun 28, 2024

Andrey2470T Jun 28, 2024

sfence Jul 1, 2024

nerzhul Jun 28, 2024

sfence Oct 2, 2024

Andrey2470T commented Jun 29, 2024 •

edited

Loading

sfence commented Jul 1, 2024

sfence commented Nov 3, 2024

API for light intensity and color at night and day #14091

Are you sure you want to change the base?

API for light intensity and color at night and day #14091

Conversation

sfence commented Dec 11, 2023 • edited Loading

To do

How to test

Zughy left a comment • edited Loading

Choose a reason for hiding this comment

sfence commented Jan 2, 2024 • edited Loading

sfence commented Feb 3, 2024 • edited Loading

Andrey2470T commented Jun 28, 2024 • edited Loading

Andrey2470T Jun 28, 2024

Choose a reason for hiding this comment

Andrey2470T Jun 28, 2024

Choose a reason for hiding this comment

Andrey2470T Jun 28, 2024

Choose a reason for hiding this comment

sfence Jul 1, 2024

Choose a reason for hiding this comment

nerzhul Jun 28, 2024

Choose a reason for hiding this comment

sfence Oct 2, 2024

Choose a reason for hiding this comment

Andrey2470T commented Jun 29, 2024 • edited Loading

sfence commented Jul 1, 2024

sfence commented Nov 3, 2024

sfence commented Dec 11, 2023 •

edited

Loading

Zughy left a comment •

edited

Loading

sfence commented Jan 2, 2024 •

edited

Loading

sfence commented Feb 3, 2024 •

edited

Loading

Andrey2470T commented Jun 28, 2024 •

edited

Loading

Andrey2470T commented Jun 29, 2024 •

edited

Loading