Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of working server to server message. #14226

Closed
wants to merge 2 commits into from

Conversation

sfence
Copy link
Contributor

@sfence sfence commented Jan 7, 2024

To do

This PR is a Work in Progress.

  • Get feedback.
  • Apply feedback.
  • Add better authorization.

How to test

  1. Compile Minetest with this branch.

  2. Create two worlds with the game devtest.

  3. To server0 world directory save file network_server_0.txt as network.conf.

  4. To server1 world directory save file network_server_1.txt as network.conf.

  5. Host server for game server0 on port 30000.

  6. Host server for game server1 on port 30000.

  7. Call command /send_msg_to_server server0 HELLO_SERVER! on server1 or
    command /send_msg_to_server server1 HELLO_SERVER! on server0.

  8. The first message is lost at the moment, so send the same message again to see it.

  9. Received message should be printed as a message for all players on the second server.

simplescreenrecorder-2024-01-07_14.31.45.mp4

@sfence sfence marked this pull request as draft January 7, 2024 12:38
@Zughy Zughy added Feature ✨ PRs that add or enhance a feature Concept approved Approved by a core dev: PRs welcomed! labels Jan 22, 2024
@sfan5
Copy link
Collaborator

sfan5 commented Jan 24, 2024

Where did the "Concept approved" come from?

@sfence
Copy link
Contributor Author

sfence commented Jan 25, 2024

Where did the "Concept approved" come from?

#5883 ?

@sfan5
Copy link
Collaborator

sfan5 commented Jan 25, 2024

I assume you meant to link #5813.
The submitter proposes a server networking solution and there is some discussion around it but I interpret this #5813 (comment) to refer to an implementation of minetest.transfer_player only.
Maybe @rubenwardy can clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concept approved Approved by a core dev: PRs welcomed! Feature ✨ PRs that add or enhance a feature @ Network Possible close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants