[nosq] Android insets API for the ContentDB dialog #15247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
@ Script API
Feature ✨
grorp
commented
Oct 7, 2024
|
|
||
| #include "clientdynamicinfo.h" | ||
|
|
||
| void push_window_info(lua_State *L, const ClientDynamicInfo &info); |
There was a problem hiding this comment.
This is in its own file because I didn't want to introduce more code duplication, but wasn't sure where to put it
| @@ -656,7 +669,7 @@ function contentdb.get_formspec_size() | |||
|
|
|||
| -- Minimum formspec size | |||
| local min_x = 15.5 | |||
| local min_y = 10 | |||
| local min_y = 9 | |||
There was a problem hiding this comment.
This was necessary to get a good grid layout on my phone again ¯\(ツ)/¯
This was referenced Oct 7, 2024
|
Closing since low priority at this time, the workaround is good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14510, this PR replaces the hardcoded extra padding in the ContentDB dialog on Android, which may waste valuable screen space depending on your device, with an API to retrieve display inset values
To do
This PR is a Ready for Review.
(I wrote this code back in May)
How to test
ContentDB dialog on desktop => should look the same as before
ContentDB dialog on Android => should respect the camera cutout, and should update in real time when you turn the screen upside-down
The same should apply for
/testfullscreenfsin Devtest.