[no sq] Safety and other fixes #15251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
@ Script API
Bugfix 🐛
sfan5
force-pushed
the
sec1234
branch
2 times, most recently
from
6eaf0f7 to
d019d69
Compare
sfan5
removed
the
Action / change needed
sfan5
commented
Oct 8, 2024
| @@ -231,143 +249,143 @@ void TestVoxelArea::test_index_xyz_all_pos() | |||
| VoxelArea v1; | |||
| UASSERTEQ(s32, v1.index(156, 25, 236), 155); | |||
|
|
|||
| VoxelArea v2(v3s16(756, 8854, -875), v3s16(-147, -9547, 669)); | |||
| UASSERTEQ(s32, v2.index(156, 25, 236), 1267138774); | |||
| VoxelArea v2(v3s16(-147, -9547, -875), v3s16(756, 8854, 669)); | |||
There was a problem hiding this comment.
note: all of these positions were not sorted, causing garbage results
SmallJoker
reviewed
Oct 8, 2024
sfan5
added
the
Action / change needed
sfan5
force-pushed
the
sec1234
branch
2 times, most recently
from
7ca1551 to
bc3a5fc
Compare
sfan5
removed
the
Action / change needed
Desour
reviewed
Oct 10, 2024
| static void set_null(lua_State *L); | ||
| // Clear the pointer in the ObjectRef (at -1). | ||
| // Throws an fatal error if the object pointer wasn't `expect`. | ||
| static void set_null(lua_State *L, void *expect); |
In particular this validates the edges of VoxelArea and fixes all the nonsense tests uncovered by it.
also add override keyword and fix overflow() behavior
concrete problem: the getEmergeThread safety check was missing there
SmallJoker
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14435
fixes https://github.com/orgs/minetest/discussions/111 (internal)
fixes https://github.com/orgs/minetest/discussions/108 (internal)
fixes https://github.com/orgs/minetest/discussions/89 (internal)
To do
This PR is Ready for Review.
How to test
see linked discussions