Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireflies API: An idea to resolve issue #2966 #3087

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions mods/fireflies/api.lua
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
-- fireflies/api.lua

fireflies = {}
-- If necessary, add other functions related to fireflies here

--------------------------------------------------------------
-- Global function to record the decoration of fireflies.
-- Perhaps other parameters can be added to improve decoration registration control.
function fireflies.register_decoration(biomes, place_on)
local mg_name = minetest.get_mapgen_setting("mg_name")

if mg_name == "v6" then
minetest.register_decoration({
name = "fireflies:firefly_low",
deco_type = "simple",
place_on = place_on,
place_offset_y = 2,
sidelen = 80,
fill_ratio = 0.0002,
y_max = 31000,
y_min = 1,
decoration = "fireflies:hidden_firefly",
})

minetest.register_decoration({
name = "fireflies:firefly_high",
deco_type = "simple",
place_on = place_on,
place_offset_y = 3,
sidelen = 80,
fill_ratio = 0.0002,
y_max = 31000,
y_min = 1,
decoration = "fireflies:hidden_firefly",
})

else
minetest.register_decoration({
name = "fireflies:firefly_low",
deco_type = "simple",
place_on = place_on,
place_offset_y = 2,
sidelen = 80,
fill_ratio = 0.0005,
biomes = biomes,
y_max = 31000,
y_min = -1,
decoration = "fireflies:hidden_firefly",
})

minetest.register_decoration({
name = "fireflies:firefly_high",
deco_type = "simple",
place_on = place_on,
place_offset_y = 3,
sidelen = 80,
fill_ratio = 0.0005,
biomes = biomes,
y_max = 31000,
y_min = -1,
decoration = "fireflies:hidden_firefly",
})
end
end
96 changes: 19 additions & 77 deletions mods/fireflies/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
-- Load support for MT game translation.
local S = minetest.get_translator("fireflies")

local modpath = minetest.get_modpath("fireflies")
dofile(modpath .. "/api.lua")

minetest.register_node("fireflies:firefly", {
description = S("Firefly"),
Expand Down Expand Up @@ -184,83 +186,23 @@ minetest.register_craft( {


-- register fireflies as decorations

if minetest.get_mapgen_setting("mg_name") == "v6" then

minetest.register_decoration({
name = "fireflies:firefly_low",
deco_type = "simple",
place_on = "default:dirt_with_grass",
place_offset_y = 2,
sidelen = 80,
fill_ratio = 0.0002,
y_max = 31000,
y_min = 1,
decoration = "fireflies:hidden_firefly",
})

minetest.register_decoration({
name = "fireflies:firefly_high",
deco_type = "simple",
place_on = "default:dirt_with_grass",
place_offset_y = 3,
sidelen = 80,
fill_ratio = 0.0002,
y_max = 31000,
y_min = 1,
decoration = "fireflies:hidden_firefly",
})

else

minetest.register_decoration({
name = "fireflies:firefly_low",
deco_type = "simple",
place_on = {
"default:dirt_with_grass",
"default:dirt_with_coniferous_litter",
"default:dirt_with_rainforest_litter",
"default:dirt"
},
place_offset_y = 2,
sidelen = 80,
fill_ratio = 0.0005,
biomes = {
"deciduous_forest",
"coniferous_forest",
"rainforest",
"rainforest_swamp"
},
y_max = 31000,
y_min = -1,
decoration = "fireflies:hidden_firefly",
})

minetest.register_decoration({
name = "fireflies:firefly_high",
deco_type = "simple",
place_on = {
"default:dirt_with_grass",
"default:dirt_with_coniferous_litter",
"default:dirt_with_rainforest_litter",
"default:dirt"
},
place_offset_y = 3,
sidelen = 80,
fill_ratio = 0.0005,
biomes = {
"deciduous_forest",
"coniferous_forest",
"rainforest",
"rainforest_swamp"
},
y_max = 31000,
y_min = -1,
decoration = "fireflies:hidden_firefly",
})

end

local place_on = {
"default:dirt_with_grass",
"default:dirt_with_coniferous_litter",
"default:dirt_with_rainforest_litter",
"default:dirt"
}
local biomes = {
"deciduous_forest",
"coniferous_forest",
"rainforest",
"rainforest_swamp"
}

local place_on_mgv6 = "default:dirt_with_grass"

fireflies.register_decoration(biomes, place_on)
fireflies.register_decoration(nil, place_on_mgv6)

-- get decoration IDs
local firefly_low = minetest.get_decoration_id("fireflies:firefly_low")
Expand Down
Loading