Skip to content

Commit

Permalink
Add benchmarks results for 041b8ee4e71de42e686cd787d7fe28e7036209eb
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions committed Jun 4, 2024
1 parent 50c48d4 commit 254f2cb
Show file tree
Hide file tree
Showing 5 changed files with 909 additions and 5 deletions.
68 changes: 67 additions & 1 deletion analyze.json
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lastUpdate": 1717187254873,
"lastUpdate": 1717538508025,
"repoUrl": "https://github.com/luau-lang/luau",
"entries": {
"luau-analyze": [
Expand Down Expand Up @@ -12868,6 +12868,72 @@
"extra": "luau-analyze"
}
]
},
{
"commit": {
"author": {
"email": "[email protected]",
"name": "JohnnyMorganz",
"username": "JohnnyMorganz"
},
"committer": {
"email": "[email protected]",
"name": "GitHub",
"username": "web-flow"
},
"distinct": true,
"id": "041b8ee4e71de42e686cd787d7fe28e7036209eb",
"message": "Fix edge case in 'findBindingAtPosition' when looking up global binding at start of file (#1254)\n\nThe 'findBindingAtPosition' AstQuery function can be used to lookup a\r\nlocal or global binding.\r\n\r\nInside of this function is a check to \"Ignore this binding if we're\r\ninside its definition. e.g. local abc = abc -- Will take the definition\r\nof abc from outer scope\".\r\n\r\nHowever, this check is incorrect when we are looking up a global binding\r\nat the start of a file.\r\n\r\nConsider a complete file with the contents:\r\n```lua\r\nlocal x = stri|ng.char(1)\r\n```\r\n\r\nand we pass the location of the marker `|` as the position to the find\r\nbinding position. We will pick up the global binding of the definition\r\n`string` coming from a builtin source (either defined via C++ code or a\r\ndefinitions file and loaded into the global scope).\r\n\r\nThe global binding `string` will have a zero position: `0,0,0,0`.\r\nHowever, the `findBindingLocalStatement` check works by looking up the\r\nAstAncestry at the binding's defined begin position *in the current\r\nsource module*. This will then incorrectly return the local statement\r\nfor `local x`, as that is at the start of the source code. Then in turn,\r\nwe assume we are in the `local abc = abc` case, and end up skipping over\r\nthe correct binding.\r\n\r\nWe fix this by checking if the binding is at the global position. If so,\r\nwe early exit because it is impossible for a global binding to be\r\ndefined in a local statement.",
"timestamp": "2024-06-04T13:53:01-07:00",
"tree_id": "c45b3bc60ee2544c0b70ee230b71f2af916b7a14",
"url": "https://github.com/luau-lang/luau/commit/041b8ee4e71de42e686cd787d7fe28e7036209eb"
},
"date": 1717538508022,
"tool": "benchmarkluau",
"benches": [
{
"name": "map-nonstrict",
"value": 4.76454,
"unit": "4ms",
"range": "±0%",
"extra": "luau-analyze"
},
{
"name": "map-strict",
"value": 5.81689,
"unit": "5ms",
"range": "±0%",
"extra": "luau-analyze"
},
{
"name": "map-dcr",
"value": 98.7591,
"unit": "ms",
"range": "±0%",
"extra": "luau-analyze"
},
{
"name": "regex-nonstrict",
"value": 7.77285,
"unit": "7ms",
"range": "±0%",
"extra": "luau-analyze"
},
{
"name": "regex-strict",
"value": 9.98941,
"unit": "9ms",
"range": "±0%",
"extra": "luau-analyze"
},
{
"name": "regex-dcr",
"value": 61548.5,
"unit": "ms",
"range": "±0%",
"extra": "luau-analyze"
}
]
}
]
}
Expand Down
250 changes: 249 additions & 1 deletion bench-codegen.json
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lastUpdate": 1717187254539,
"lastUpdate": 1717538507709,
"repoUrl": "https://github.com/luau-lang/luau",
"entries": {
"callgrind codegen": [
Expand Down Expand Up @@ -35124,6 +35124,254 @@
"extra": "luau-codegen"
}
]
},
{
"commit": {
"author": {
"email": "[email protected]",
"name": "JohnnyMorganz",
"username": "JohnnyMorganz"
},
"committer": {
"email": "[email protected]",
"name": "GitHub",
"username": "web-flow"
},
"distinct": true,
"id": "041b8ee4e71de42e686cd787d7fe28e7036209eb",
"message": "Fix edge case in 'findBindingAtPosition' when looking up global binding at start of file (#1254)\n\nThe 'findBindingAtPosition' AstQuery function can be used to lookup a\r\nlocal or global binding.\r\n\r\nInside of this function is a check to \"Ignore this binding if we're\r\ninside its definition. e.g. local abc = abc -- Will take the definition\r\nof abc from outer scope\".\r\n\r\nHowever, this check is incorrect when we are looking up a global binding\r\nat the start of a file.\r\n\r\nConsider a complete file with the contents:\r\n```lua\r\nlocal x = stri|ng.char(1)\r\n```\r\n\r\nand we pass the location of the marker `|` as the position to the find\r\nbinding position. We will pick up the global binding of the definition\r\n`string` coming from a builtin source (either defined via C++ code or a\r\ndefinitions file and loaded into the global scope).\r\n\r\nThe global binding `string` will have a zero position: `0,0,0,0`.\r\nHowever, the `findBindingLocalStatement` check works by looking up the\r\nAstAncestry at the binding's defined begin position *in the current\r\nsource module*. This will then incorrectly return the local statement\r\nfor `local x`, as that is at the start of the source code. Then in turn,\r\nwe assume we are in the `local abc = abc` case, and end up skipping over\r\nthe correct binding.\r\n\r\nWe fix this by checking if the binding is at the global position. If so,\r\nwe early exit because it is impossible for a global binding to be\r\ndefined in a local statement.",
"timestamp": "2024-06-04T13:53:01-07:00",
"tree_id": "c45b3bc60ee2544c0b70ee230b71f2af916b7a14",
"url": "https://github.com/luau-lang/luau/commit/041b8ee4e71de42e686cd787d7fe28e7036209eb"
},
"date": 1717538507703,
"tool": "benchmarkluau",
"benches": [
{
"name": "base64",
"value": 11.585,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "chess",
"value": 52.002,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "life",
"value": 23.356,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "matrixmult",
"value": 9.335,
"unit": "9ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "mesh-normal-scalar",
"value": 13.016,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "pcmmix",
"value": 1.38,
"unit": "1ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "qsort",
"value": 41.47,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "sha256",
"value": 4.56,
"unit": "4ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "ack",
"value": 40.016,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "binary-trees",
"value": 20.939,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "fannkuchen-redux",
"value": 3.892,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "fixpoint-fact",
"value": 48.952,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "heapsort",
"value": 7.734,
"unit": "7ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "mandel",
"value": 40.416,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "n-body",
"value": 9.707,
"unit": "9ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "qt",
"value": 24.927,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "queen",
"value": 0.805,
"unit": "0ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "scimark",
"value": 24.636,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "spectral-norm",
"value": 2.444,
"unit": "2ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "sieve",
"value": 83.259,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "3d-cube",
"value": 3.737,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "3d-morph",
"value": 3.748,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "3d-raytrace",
"value": 3.28,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "controlflow-recursive",
"value": 3.463,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "crypto-aes",
"value": 7.19,
"unit": "7ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "fannkuch",
"value": 6.167,
"unit": "6ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "math-cordic",
"value": 3.768,
"unit": "3ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "math-partial-sums",
"value": 1.917,
"unit": "1ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "n-body-oop",
"value": 13.739,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "tictactoe",
"value": 62.957,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "trig",
"value": 6.65,
"unit": "6ms",
"range": "±0.000%",
"extra": "luau-codegen"
},
{
"name": "voxelgen",
"value": 27.655,
"unit": "ms",
"range": "±0.000%",
"extra": "luau-codegen"
}
]
}
]
}
Expand Down
Loading

0 comments on commit 254f2cb

Please sign in to comment.