-
Notifications
You must be signed in to change notification settings - Fork 397
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Include module name for definitions files (#861)
Closes #818 We set the `moduleName` of the source module to the provided `packageName`. This then populates the relevant `definitionModuleName`'s on CTV/FTV/TTVs, so it allows us to lookup where they originated from. The one place I can see this having an impact inside of Luau code is the following: https://github.com/Roblox/luau/blob/1fa8311a188a932233d2ce2bc6412e5bab37c035/Analysis/src/Error.cpp#L70-L90 Which will potentially change they way error messages are formatted. Should there be a way to exclude definition files when calling `getDefinitionModuleName`, so we can preserve this behaviour?
- Loading branch information
1 parent
74c5320
commit ae53051
Showing
2 changed files
with
29 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters