Sync to upstream/release/599 #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes a bug in CodeAllocator that needs to be fixed properly
alexmccord
approved these changes
Oct 13, 2023
Comment on lines
+1063
to
+1082
| if (AstStatForIn* statForIn = (*it)->as<AstStatForIn>(); statForIn && !statForIn->body->hasEnd) | ||
| result.emplace("end", AutocompleteEntry{AutocompleteEntryKind::Keyword}); | ||
| else if (AstStatFor* statFor = (*it)->as<AstStatFor>(); statFor && !statFor->body->hasEnd) | ||
| result.emplace("end", AutocompleteEntry{AutocompleteEntryKind::Keyword}); | ||
| else if (AstStatIf* statIf = (*it)->as<AstStatIf>()) | ||
| { | ||
| bool hasEnd = statIf->thenbody->hasEnd; | ||
| if (statIf->elsebody) | ||
| { | ||
| if (AstStatBlock* elseBlock = statIf->elsebody->as<AstStatBlock>()) | ||
| hasEnd = elseBlock->hasEnd; | ||
| } | ||
|
|
||
| if (!hasEnd) | ||
| result.emplace("end", AutocompleteEntry{AutocompleteEntryKind::Keyword}); | ||
| } | ||
| else if (AstStatWhile* statWhile = (*it)->as<AstStatWhile>(); statWhile && !statWhile->body->hasEnd) | ||
| result.emplace("end", AutocompleteEntry{AutocompleteEntryKind::Keyword}); | ||
| else if (AstExprFunction* exprFunction = (*it)->as<AstExprFunction>(); exprFunction && !exprFunction->body->hasEnd) | ||
| result.emplace("end", AutocompleteEntry{AutocompleteEntryKind::Keyword}); |
There was a problem hiding this comment.
question: will this be deleted once LuauAutocompleteDoEnd is clipped? since its all covered by the AstStatBlock? (i guess apart from AstStatIf)
There was a problem hiding this comment.
I hadn't actually thought about that. I think so in theory?
I'll give it a shot when it's time to clip the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
CLI/FileUtils.cppby @SamuraiCrow Improve POSIX compliance in CLI/FileUtils.cpp #1064AstStat*::hasEndis deprecated; useAstStatBlock::hasEndinstead#operatorgetfenvandsetfenvCompiler
New Type Solver
Native Codegen
Co-authored-by: Aaron Weiss [email protected]
Co-authored-by: Alexander McCord [email protected]
Co-authored-by: Andy Friesen [email protected]
Co-authored-by: Vighnesh Vijay [email protected]
Co-authored-by: Vyacheslav Egorov [email protected]