Fix gcc-13 build on Linux #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint8_t requires stdint.h include. Also remove redundant consts as a drive-by.
vegorov-rbx
approved these changes
Nov 17, 2023
|
It looks like this was missed because build/ubuntu is still on 20.04 LTS. ubuntu-latest is on 22.04 since last year. We should upgrade - I'm not sure if this breaks coverage build but we could always run coverage separately from the main build. |
|
Ah - coverage is already separate. It looks like we also need releases to stay on ubuntu-20 for glibc compatibility per 685ca02 but maybe we can keep regular builds at ubuntu-latest? We could also use ubuntu-latest for web builds as these just produce a Wasm binary that doesn't have glibc dependencies. |
|
This was fixed in #1110. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint8_t requires stdint.h include. Also remove redundant consts as a drive-by.