keyof - fix LUAU_ASSERT when there's only one key entry #1388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1387
Was suggested by @alexmccord
I changed
singletons[0]
tosingletons.front()
, unsure if that makes a huge difference, and then I added the rest of the things needed for the return type.Maybe it's also the ideal location since doing it before looping through
keys
won't add the string into the type arena.I put comments next to it based on how I thought it would make sense.
LUAU_ASSERT
seems to trigger when there's only one entry being put inside a UnionType. It's as if it was put there for quality.Allow edits by maintainers is enabled.
I tested this with a quick Unit Test something like