Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give vector its fields #1526

Closed
wants to merge 2 commits into from
Closed

Conversation

jackdotink
Copy link
Contributor

No description provided.

@petrihakkinen
Copy link
Contributor

Does this mean that accessing w will cause a type-checking error in 4-wide mode?

@jackdotink
Copy link
Contributor Author

Yes but it also means that vector + vector will be a type error. This is hopefully a temporary fix.

@vegorov-rbx
Copy link
Collaborator

Thank you for the contribution, similar change was included and extended in #1552

@vegorov-rbx vegorov-rbx closed this Dec 3, 2024
@vegorov-rbx
Copy link
Collaborator

vegorov-rbx commented Dec 3, 2024

Does this mean that accessing w will cause a type-checking error in 4-wide mode?

We are currently limiting LUA_VECTOR_SIZE effects to the runtime components.

'w' field can be added by updating existing built-in definitions, the global type arena can be temporarily unfrozen for that.
At Roblox, the vector has even more methods and fields which are added that way.

With improved documentation, we might have a section of 4-wide vector handling in such way.

@petrihakkinen
Copy link
Contributor

That makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants