Evol/drawer #4

lucas-amiaud · 2022-03-02T14:51:11Z

No description provided.

ThomLlobEce · 2022-03-14T15:15:54Z

templates/admin/assets/scss/_popin.scss

-    background-color: #ffffff;
-    box-shadow: 0 3px 5px 1px rgba(#000000, .25);
+    background-color: #fff;
+    box-shadow: 0 3px 5px 1px rgba(#000, .25);
    border-radius: 3px;


T'as pas de variables pour les border-radius ?

ThomLlobEce · 2022-03-14T15:18:39Z

templates/admin/src/components/theme/drawer/Drawer.tsx

+        return 'full';
+      }
+
+      return width < widthMediumScreen ? 60 : defaultSize;


Suggested change

return width < widthMediumScreen ? 60 : defaultSize;

return width < widthMediumScreen ? largeSize : defaultSize;

GeoffreyEhrmann · 2022-03-21T18:04:08Z

templates/admin/src/components/theme/drawer/UncontrolledDrawer.tsx

+import PlumeAdminTheme from '../../../lib/plume-admin-theme/PlumeAdminTheme';
+
+/**
+ * When a drawer is a all page, there is no state to control its opening / closing


is a whole page* ?
pas compris pourquoi il y aurait pas de state ?

y a pas de state dans le parent pour controler l'ouverture / la fermeture. Donc c'est lui même qui gère son état d'ouverture / fermeture et le parent ne se charge de rien

Dans ce cas, le composant est mal nommé, c'est plutôt fullPageDrawer ou quelque chose dans le genre

GeoffreyEhrmann · 2022-03-21T18:08:35Z

templates/admin/src/lib/plume-admin-users/pages/UsersEdit.tsx

+                  <this.theme.actionButton
+                    iconName="delete"
+                    style={ActionStyle.DANGER}
+                    onClick={confirmDeleteUser.handleConfirmation(() => tryDeleteUser(userId))}


dis moi si je me trompe, mais on passe une fonction ici, alors que dans tous les cas l'action "tryDeleteUser(userId)" est override dans la modale ?

je comprends pas, pourquoi il serait override dans un composant générique ?

benjaminchardin2 · 2022-03-23T21:15:16Z

templates/admin/src/components/theme/drawer/UncontrolledDrawer.tsx

+  const [isDrawerOpened, toggleDrawerOpening] = useToggle(false);
+
+  const uncontrolledClose = () => {
+    toggleDrawerOpening();


toggleDrawer tout court non ? je trouve ça bizarre d'appler opening dans close

benjaminchardin2 · 2022-03-23T21:16:31Z

templates/admin/src/lib/plume-admin-users/pages/UsersEdit.tsx

+            .save(userToSave)
+            .then((createdUser) => {
+              updateUsersAndRoles();
+              this.notificationEngine.addSuccess(this.messages.t('message.changes-saved'));


si createdUser est undefined on veut pas de notif de succès non ?

ca peut pas arriver, si la création se passe bien il sera renvoyé

ok du coup pas besoin du if juste en dessous

benjaminchardin2 · 2022-03-23T21:18:30Z

templates/admin/src/lib/plume-admin-users/pages/UsersEdit.tsx

+                </this.theme.actionButton>
+                <this.theme.actionButton
+                  style={ActionStyle.DANGER}
+                  onClick={confirmDeleteUser.confirm(() => tryDeleteUser(userId))}


on peut pas renommer tryDeleteUser ? parce que chaque appel api au final c'est un peu un essai qui peut fail

# Conflicts: # templates/admin/assets/scss/_material-override.scss # templates/admin/assets/scss/layouts/_index.scss # templates/admin/src/components/theme/popin/Popin.tsx # templates/admin/src/i18n/translations/Translations.ts # templates/admin/src/i18n/translations/en.ts # templates/admin/src/i18n/translations/fr.ts

amanteaux · 2022-06-23T07:22:23Z

templates/admin/assets/scss/components/_popin.scss

    border-radius: $border-radius-3;
    padding: $spacer-6;
+    max-width: 600px;


Pourquoi ça ?

amanteaux · 2022-06-23T07:23:14Z

templates/admin/assets/scss/modules/_variables.module.scss

@@ -0,0 +1,9 @@
+@use "../variables" as *;
+
+:export{


Je ne comprends pas bien à quoi sert ce fichier

amanteaux · 2022-06-23T07:29:13Z

templates/admin/src/lib/plume-admin-theme/drawer/DrawerProps.ts

+
+export interface DrawerTypeProps extends CommonDrawerProps {
+  open: boolean,
+  close: () => void,


Je ne comprends pas ces 2 propriétés.

amanteaux · 2022-06-23T07:32:17Z

templates/admin/src/components/theme/drawer/Drawer.tsx

+import { DrawerTypeProps } from '../../../lib/plume-admin-theme/drawer/DrawerProps';
+import ActionStyle from '../../../lib/plume-admin-theme/action/ActionStyle';
+
+export default function Drawer(


Antoine LL Tu penses qu'on peut reprendre des choses du slider de la VEL ?

amanteaux · 2022-06-23T07:32:39Z

templates/admin/src/components/theme/drawer/Drawer.tsx

+  // Returns width percentage of drawer
+  const drawerSize = () => {
+    const defaultSize = 40;
+    const largeSize = 60;


A sortir de la fonction pour ne pas redéfinir les valeurs à chaque fois

amanteaux · 2022-06-23T07:34:35Z

templates/admin/src/lib/plume-admin-theme/drawer/DrawerProps.ts

+  title: string,
+  children: React.ReactNode,
+  size?: number | string,
+  sizedByWidth?: boolean,


Qu'est ce que ça veut dire ?

amanteaux · 2022-06-23T07:36:44Z

templates/admin/src/components/theme/drawer/UncontrolledDrawer.tsx

+import PlumeAdminTheme from '../../../lib/plume-admin-theme/PlumeAdminTheme';
+
+/**
+ * When a drawer is a all page, there is no state to control its opening / closing


Dans ce cas, le composant est mal nommé, c'est plutôt fullPageDrawer ou quelque chose dans le genre

amanteaux · 2022-06-23T07:39:15Z

templates/admin/src/components/theme/form/fields/InputSelect.tsx

  return (
-    <NativeSelect
+    <TextField


Pourquoi TextField et pas Select ?

amanteaux · 2022-06-23T07:40:06Z

templates/admin/src/components/theme/popin/Popin.tsx

@@ -19,16 +21,19 @@ export function Popin({
 }

 export function PopinCloseWithoutSaving(
-  { confirmCloseWithoutSaving, closeWithoutSavingAction }: PopinCloseWithoutSavingProps,
+  { title, confirmCloseWithoutSaving, closeWithoutSavingAction }: PopinCloseWithoutSavingProps,


Le titre doit être optionnel

amanteaux · 2022-06-23T07:40:43Z

templates/admin/src/lib/plume-admin-theme/popin/PopinProps.ts

 };

 export type PopinCloseWithoutSavingProps = {
+  title: string,


Evol/fix inputs

lucas-amiaud added 9 commits February 4, 2022 16:07

implement generic drawer and user edit form

e33d2c5

rearrange project components

09aad91

merge lists and filters

e8b489c

merge lists and filters

9e81c71

merge list and filters

41e7fcb

merge list and filters

573d116

a bit of responsive

9e8603b

merge lists and filters

814657f

Merge branch 'evol/lists-and-filters' into evol/drawer

3217a2a

ThomLlobEce reviewed Mar 14, 2022

View reviewed changes

Merge branch 'evol/lists-and-filters' into evol/drawer

e06ad10

GeoffreyEhrmann reviewed Mar 21, 2022

View reviewed changes

benjaminchardin2 reviewed Mar 23, 2022

View reviewed changes

lucas-amiaud added 11 commits March 24, 2022 09:32

pr feedback resolution

3b9a62f

Merge branch 'evol/lists-and-filters' into evol/drawer

9104597

Merge branch 'evol/lists-and-filters' into evol/drawer

a464d77

Merge branch 'evol/lists-and-filters' into evol/drawer

25ee52d

Merge branch 'evol/lists-and-filters' into evol/drawer

143bbe0

Merge branch 'evol/lists-and-filters' into evol/drawer

7528548

Merge branch 'evol/lists-and-filters' into evol/drawer

f133c5f

Merge branch 'evol/lists-and-filters' into evol/drawer

bc4adc8

Merge branch 'evol/lists-and-filters' into evol/drawer

2589eb9

fix eslint

2d6b1c1

amanteaux suggested changes Jun 23, 2022

View reviewed changes

lucas-amiaud pushed a commit that referenced this pull request Jun 30, 2022

Merge pull request #4 from lucas-amiaud/evol/fix-inputs

f9ebd17

Evol/fix inputs

Merge branch 'evol/lists-and-filters' into evol/drawer

9721d99

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Evol/drawer #4

Evol/drawer #4

lucas-amiaud commented Mar 2, 2022

ThomLlobEce Mar 14, 2022

ThomLlobEce Mar 14, 2022

GeoffreyEhrmann Mar 21, 2022

lucas-amiaud Mar 22, 2022

amanteaux Jun 23, 2022

GeoffreyEhrmann Mar 21, 2022

lucas-amiaud Mar 22, 2022

benjaminchardin2 Mar 23, 2022

benjaminchardin2 Mar 23, 2022

lucas-amiaud Mar 24, 2022

benjaminchardin2 Mar 30, 2022

benjaminchardin2 Mar 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

amanteaux Jun 23, 2022

	return width < widthMediumScreen ? 60 : defaultSize;
	return width < widthMediumScreen ? largeSize : defaultSize;

Evol/drawer #4

Are you sure you want to change the base?

Evol/drawer #4

Conversation

lucas-amiaud commented Mar 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment