NativeAoT support #107
Open
NativeAoT support #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e now properly annotated
|
I forgot i had to do it, but to make the Godot sample work with PublishAoT another necessary change is to the json serialization used to communicate with the lobby server, have it use JsonTypeInfos (or JsonSerializerContext source generation) instead of reflection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Removing code when "AOT_ENABLED" is set is no longer necessary with .net9.0, thanks to Intrinsic APIs marked RequiresDynamicCode now including MethodInfo.MakeGenericMethod.
I annotated the entire library (and tests) with the required attributes and provided overloads that don't require dynamically accessed code to the few methods that still require it (mostly due to json serialization).
Also made Backdash.Analyzers compatible with visual studio on the way, for convenience.
Tests succeed both with and without PublishAoT, the Godot sample also exports and plays with PublishAoT with a single minimal change: the export setting "Embed Build Outputs" makes it crash on startup.