In addition to handling drag gesture changes & ending, also handle ca…

[juhieta]

…ncelled drag gesture. Fixes #148.

[lucaszischka]

Hello Jukka Hietanen,
first of all, thank you for taking the time to fix this issue yourself. ❤️
Im currently very busy, so I don't have time to test this PR; however the code LGTM and after you fix the MacOS build I will merge it into main. Also consider adding

v3.1.2

• Fixed drag animation bug When swiping up from safe area to show app switcher, bottom sheet can be dragged to position not included in switchablePositions #148 (In addition to handling drag gesture changes & ending, also handle ca… #149, thx @juhieta)

to CHANGELOG.md.

Anyway, I will not release a new version until I had time to test it. This means for you (or anyone else having this issue), that you will either have to use the main branch or your current fork.

Sorry for the inconvenience and thank you very much for helping me out!

Greetings from Munich,
Lucas

[zchwyng]

Thanks! ❤️❤️ Can we get this merged? This bug makes dragging from the bottom pretty much a no go, imho. I've tested it on a real device with iOS 17.3.1 on an iPhone 12 mini and a bunch of different iPhone and iPad simulators with iOS 17.0. I will try this in production on a small user base.

[fickledogfish]

@juhieta could you apply this patch to the PR? It should fix the macOS build. 😺

diff --git a/Sources/BottomSheet/Helper/Extensions/ViewExtension.swift b/Sources/BottomSheet/Helper/Extensions/ViewExtension.swift
index 4a49adf..689f760 100644
--- a/Sources/BottomSheet/Helper/Extensions/ViewExtension.swift
+++ b/Sources/BottomSheet/Helper/Extensions/ViewExtension.swift
@@ -13,7 +13,7 @@ import Combine
 internal extension View {
     /// A backwards compatible wrapper for iOS 14 onChange
     @ViewBuilder func valueChanged<T: Equatable>(value: T, onChange: @escaping (T) -> Void) -> some View {
-        if #available(iOS 14.0, *) {
+        if #available(iOS 14.0, macOS 11.0, *) {
             self.onChange(of: value, perform: onChange)
         } else {
             self.onReceive(Just(value)) { (value) in

[juhieta]

Hi, sorry about delay and will do asap! 😊

[juhieta]

Now pushed the macOS fix @fickledogfish. @lucaszischka can this now be merged to main?