Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in multi-host configuratiion #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r4nd0m
Copy link

@r4nd0m r4nd0m commented Oct 22, 2020

When the tomcat is configured for multiple hosts, the following message is being displayed on startup:
"static path [/opt/lucee/web/] for servlet init param [lucee-web-directory] is not allowed. Path must use a web context specific placeholder"
Tha cause is a hardcoded lucee-web-directory.

When the tomcat is configured for multiple hosts, the following message is being displayed on startup:
"static path [/opt/lucee/web/] for servlet init param [lucee-web-directory] is not allowed. Path must use a web context specific placeholder"
Tha cause is a hardcoded lucee-web-directory.
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@cinco cinco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats ok, for me

@justincarter
Copy link
Member

justincarter commented Nov 27, 2020 via email

@r4nd0m
Copy link
Author

r4nd0m commented Nov 30, 2020

I think this would affect all existing web context paths (e.g. /opt/lucee/web/logs would become /opt/lucee/web/{web-context-label}/logs) so some users volume mappings could fail. We might need to solve this a slightly different way so that use cases for existing paths aren't impacted.

Good point @justincarter, how about adding:
<labels><label id="some_id_hash" name="./"/></labels>
to the /opt/lucee/server/lucee-server/context/lucee-server.xml
so we have a default label whose path will be resolved to the /opt/lucee/web/ in case we have only one context?

I tested it in my single-context container by renaming the label (without changing the path to the config file, it has been changed automatically) and it looks like that worked
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants