Skip to content

Commit

Permalink
Revert #1158 (#1250)
Browse files Browse the repository at this point in the history
  • Loading branch information
pilcrowonpaper authored Nov 6, 2023
1 parent c5816e3 commit 3c8e8dc
Show file tree
Hide file tree
Showing 6 changed files with 300 additions and 10 deletions.
6 changes: 6 additions & 0 deletions .auri/$9i49vkeh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
package: "lucia" # package name
type: "patch" # "major", "minor", "patch"
---

Revert #1158
6 changes: 6 additions & 0 deletions .auri/$z7910syc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
package: "lucia" # package name
type: "patch" # "major", "minor", "patch"
---

Remove `nanoid` dependency
4 changes: 0 additions & 4 deletions packages/lucia/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,5 @@
"@types/node": "^18.6.2",
"prettier": "^2.3.0",
"vitest": "^0.33.0"
},
"dependencies": {
"@noble/hashes": "1.3.2",
"nanoid": "5.0.1"
}
}
28 changes: 28 additions & 0 deletions packages/lucia/src/scrypt/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { expect, test } from "vitest";
import { scrypt } from "./index.js";
import { scryptSync as nodeScrypt } from "node:crypto";
import { generateRandomString } from "../utils/crypto.js";

test("scrypt() output matches crypto", async () => {
const password = generateRandomString(16);
const salt = generateRandomString(16);
const scryptHash = await scrypt(
new TextEncoder().encode(password),
new TextEncoder().encode(salt),
{
N: 16384,
r: 16,
p: 1,
dkLen: 64
}
);
const cryptoHash = new Uint8Array(
nodeScrypt(password, salt, 64, {
N: 16384,
p: 1,
r: 16,
maxmem: 128 * 16384 * 16 * 2
}).buffer
);
expect(cryptoHash).toStrictEqual(scryptHash);
});
244 changes: 244 additions & 0 deletions packages/lucia/src/scrypt/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,244 @@
export const scrypt = async (
password: Uint8Array,
salt: Uint8Array,
options: ScryptOptions
): Promise<Uint8Array> => {
const { N, r, p } = options;
const dkLen = options.dkLen ?? 32;
const maxmem = 1024 ** 3 + 1024;
const blockSize = 128 * r;
const blockSize32 = blockSize / 4;
if (
N <= 1 ||
(N & (N - 1)) !== 0 ||
N >= 2 ** (blockSize / 8) ||
N > 2 ** 32
) {
throw new Error(
"Scrypt: N must be larger than 1, a power of 2, less than 2^(128 * r / 8) and less than 2^32"
);
}
if (p < 0 || p > ((2 ** 32 - 1) * 32) / blockSize) {
throw new Error(
"Scrypt: p must be a positive integer less than or equal to ((2^32 - 1) * 32) / (128 * r)"
);
}
if (dkLen < 0 || dkLen > (2 ** 32 - 1) * 32) {
throw new Error(
"Scrypt: dkLen should be positive integer less than or equal to (2^32 - 1) * 32"
);
}
const memUsed = blockSize * (N + p);
if (memUsed > maxmem) {
throw new Error(
`Scrypt: parameters too large, ${memUsed} (128 * r * (N + p)) > ${maxmem} (maxmem)`
);
}
const B = await pbkdf2(password, salt, { c: 1, dkLen: blockSize * p });
const B32 = u32(B);
const V = u32(new Uint8Array(blockSize * N));
const tmp = u32(new Uint8Array(blockSize));
for (let pi = 0; pi < p; pi++) {
const Pi = blockSize32 * pi;
for (let i = 0; i < blockSize32; i++) V[i] = B32[Pi + i]; // V[0] = B[i]
for (let i = 0, pos = 0; i < N - 1; i++) {
BlockMix(V, pos, V, (pos += blockSize32), r); // V[i] = BlockMix(V[i-1]);
await new Promise<void>((r) => r()); // await next tick
}
BlockMix(V, (N - 1) * blockSize32, B32, Pi, r); // Process last element
for (let i = 0; i < N; i++) {
// First u32 of the last 64-byte block (u32 is LE)
const j = B32[Pi + blockSize32 - 16] % N; // j = Integrify(X) % iterations
for (let k = 0; k < blockSize32; k++) {
tmp[k] = B32[Pi + k] ^ V[j * blockSize32 + k]; // tmp = B ^ V[j]
}

BlockMix(tmp, 0, B32, Pi, r); // B = BlockMix(B ^ V[j])
await new Promise<void>((r) => r()); // await next tick
}
}
const res = await pbkdf2(password, B, { c: 1, dkLen });
B.fill(0);
V.fill(0);
tmp.fill(0);
return res;
};

const rotl = (a: number, b: number): number => (a << b) | (a >>> (32 - b));

const XorAndSalsa = (
prev: Uint32Array,
pi: number,
input: Uint32Array,
ii: number,
out: Uint32Array,
oi: number
): void => {
const y00 = prev[pi++] ^ input[ii++],
y01 = prev[pi++] ^ input[ii++];
const y02 = prev[pi++] ^ input[ii++],
y03 = prev[pi++] ^ input[ii++];
const y04 = prev[pi++] ^ input[ii++],
y05 = prev[pi++] ^ input[ii++];
const y06 = prev[pi++] ^ input[ii++],
y07 = prev[pi++] ^ input[ii++];
const y08 = prev[pi++] ^ input[ii++],
y09 = prev[pi++] ^ input[ii++];
const y10 = prev[pi++] ^ input[ii++],
y11 = prev[pi++] ^ input[ii++];
const y12 = prev[pi++] ^ input[ii++],
y13 = prev[pi++] ^ input[ii++];
const y14 = prev[pi++] ^ input[ii++],
y15 = prev[pi++] ^ input[ii++];
let x00 = y00,
x01 = y01,
x02 = y02,
x03 = y03,
x04 = y04,
x05 = y05,
x06 = y06,
x07 = y07,
x08 = y08,
x09 = y09,
x10 = y10,
x11 = y11,
x12 = y12,
x13 = y13,
x14 = y14,
x15 = y15;
for (let i = 0; i < 8; i += 2) {
x04 ^= rotl((x00 + x12) | 0, 7);
x08 ^= rotl((x04 + x00) | 0, 9);
x12 ^= rotl((x08 + x04) | 0, 13);
x00 ^= rotl((x12 + x08) | 0, 18);
x09 ^= rotl((x05 + x01) | 0, 7);
x13 ^= rotl((x09 + x05) | 0, 9);
x01 ^= rotl((x13 + x09) | 0, 13);
x05 ^= rotl((x01 + x13) | 0, 18);
x14 ^= rotl((x10 + x06) | 0, 7);
x02 ^= rotl((x14 + x10) | 0, 9);
x06 ^= rotl((x02 + x14) | 0, 13);
x10 ^= rotl((x06 + x02) | 0, 18);
x03 ^= rotl((x15 + x11) | 0, 7);
x07 ^= rotl((x03 + x15) | 0, 9);
x11 ^= rotl((x07 + x03) | 0, 13);
x15 ^= rotl((x11 + x07) | 0, 18);
x01 ^= rotl((x00 + x03) | 0, 7);
x02 ^= rotl((x01 + x00) | 0, 9);
x03 ^= rotl((x02 + x01) | 0, 13);
x00 ^= rotl((x03 + x02) | 0, 18);
x06 ^= rotl((x05 + x04) | 0, 7);
x07 ^= rotl((x06 + x05) | 0, 9);
x04 ^= rotl((x07 + x06) | 0, 13);
x05 ^= rotl((x04 + x07) | 0, 18);
x11 ^= rotl((x10 + x09) | 0, 7);
x08 ^= rotl((x11 + x10) | 0, 9);
x09 ^= rotl((x08 + x11) | 0, 13);
x10 ^= rotl((x09 + x08) | 0, 18);
x12 ^= rotl((x15 + x14) | 0, 7);
x13 ^= rotl((x12 + x15) | 0, 9);
x14 ^= rotl((x13 + x12) | 0, 13);
x15 ^= rotl((x14 + x13) | 0, 18);
}
out[oi++] = (y00 + x00) | 0;
out[oi++] = (y01 + x01) | 0;
out[oi++] = (y02 + x02) | 0;
out[oi++] = (y03 + x03) | 0;
out[oi++] = (y04 + x04) | 0;
out[oi++] = (y05 + x05) | 0;
out[oi++] = (y06 + x06) | 0;
out[oi++] = (y07 + x07) | 0;
out[oi++] = (y08 + x08) | 0;
out[oi++] = (y09 + x09) | 0;
out[oi++] = (y10 + x10) | 0;
out[oi++] = (y11 + x11) | 0;
out[oi++] = (y12 + x12) | 0;
out[oi++] = (y13 + x13) | 0;
out[oi++] = (y14 + x14) | 0;
out[oi++] = (y15 + x15) | 0;
};

const pbkdf2 = async (
password: Uint8Array,
salt: Uint8Array,
options: {
c: number;
dkLen: number;
}
): Promise<Uint8Array> => {
const pwKey = await crypto.subtle.importKey(
"raw",
password,
"PBKDF2",
false,
["deriveBits"]
);
const keyBuffer = await crypto.subtle.deriveBits(
{
name: "PBKDF2",
hash: "SHA-256",
salt,
iterations: options.c
},
pwKey,
options.dkLen * 8
);
return new Uint8Array(keyBuffer);
};

const BlockMix = (
input: Uint32Array,
ii: number,
out: Uint32Array,
oi: number,
r: number
): void => {
let head = oi + 0;
let tail = oi + 16 * r;
for (let i = 0; i < 16; i++) out[tail + i] = input[ii + (2 * r - 1) * 16 + i];
for (let i = 0; i < r; i++, head += 16, ii += 16) {
XorAndSalsa(out, tail, input, ii, out, head);
if (i > 0) tail += 16;
XorAndSalsa(out, head, input, (ii += 16), out, tail);
}
};

const u32 = (arr: Uint8Array): Uint32Array => {
return new Uint32Array(
arr.buffer,
arr.byteOffset,
Math.floor(arr.byteLength / 4)
);
};

type ScryptOptions = {
N: number;
r: number;
p: number;
dkLen?: number;
maxmem?: number;
};

/*
The MIT License (MIT)
Copyright (c) 2022 Paul Miller (https://paulmillr.com)
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the “Software”), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
*/
22 changes: 16 additions & 6 deletions packages/lucia/src/utils/crypto.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
import { LuciaError } from "../auth/error.js";
import { scryptAsync as scrypt } from "@noble/hashes/scrypt";
import { customAlphabet } from "nanoid";
import { scrypt } from "../scrypt/index.js";

export const generateRandomString = (length: number, alphabet?: string) => {
const DEFAULT_ALPHABET = "abcdefghijklmnopqrstuvwxyz1234567890";
const customNanoid = customAlphabet(alphabet ?? DEFAULT_ALPHABET);
return customNanoid(length);
const DEFAULT_ALPHABET = "abcdefghijklmnopqrstuvwxyz1234567890";

export const generateRandomString = (
length: number,
alphabet: string = DEFAULT_ALPHABET
) => {
const randomUint32Values = new Uint32Array(length);
crypto.getRandomValues(randomUint32Values);
const u32Max = 0xffffffff;
let result = "";
for (let i = 0; i < randomUint32Values.length; i++) {
const rand = randomUint32Values[i] / (u32Max + 1);
result += alphabet[Math.floor(alphabet.length * rand)];
}
return result;
};

export const generateScryptHash = async (s: string): Promise<string> => {
Expand Down

0 comments on commit 3c8e8dc

Please sign in to comment.