-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#89] docs: draft-mode 번역 #117
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서의 전체적인 내용이 App Router와 관련된 것으로 이해해서 (Step 1: Create and access the API route)
description을
Page Router에서 App Router로 변경
하는 것이 더 적절하다는 생각이 들었습니다!제가 잘못 이해한 내용이 있을 수 있어서 의견 검토 한번 부탁드리겠습니다 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요! 저도 말씀 주신 부분에 대해 일정부분 동의하지만, 원본 공식문서의 한글 번역본이라는 프로젝트 특성상 내용의 임의 변경에는 조금 조심스럽게 생각됩니다.
지금 시점에서는 제안해주신 사항에 대해 반려 드려야 할 것 같습니다.
대신 vercel/next.js 레포에 pr을 올려보시는 방법도 있을 것 같습니다! docs 수정 관련한 컨트리뷰션에 대해 관대하고, pr에서 커뮤니티의 토론도 잘 이루어지는 것 같이 보였습니다.
프로젝트에 시간과 애정 투자해주셔서 항상 감사합니다. 🥰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인해주셔서 감사합니다! 며칠 휴가를 다녀오느라 답장이 늦었습니다 😥
말씀주신 내용처럼 App Router에도 동일한 draft mode 문서가 있기 때문에 유지하는게 적절할 것 같습니다! 이 부분을 제가 확인을 못했었네요.. ㅎㅎ
공식 문서에 제안하는 방법도 알려주셔서 감사합니다! 다음에도 좋은 기회가 있다면 기여해보도록 하겠습니다☺️
이번 번역 문서에도 참여할 수 있는 기회를 주셔서 감사드립니다