Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a streaming result set #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bravefoot
Copy link

Allow users who want access to an underlying result set that is large to
do so through use of streamed statements

Allow users who want access to an underlying result set that is large to
do so through use of streamed statements
Copy link
Contributor

@tmccombs tmccombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. But what is the usecase where the asIterator method isn't sufficient?

* This allows for interacting with large data sets with less risk of OutOfMemoryErrors.
* Many JDBC connectors will not allow for additional queries to the connection until the
* returned ResultSet has been closed.
* @param fetchSize the number of rows to fetch at a time, defaults to 100. If the JDBC Driver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this default come from? It seems like the fetchSize is required here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants