Only write verbose worker logs when verbosity is --worker_verbose or higher #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadenPete
reviewed
Nov 1, 2024
| // If this is a cancel request, we need to cancel a previously sent WorkRequest | ||
| // Arguments and inputs fields on cancel requests "must be empty and should be ignored" | ||
| if (request.getCancel()) { | ||
| System.err.println(s"Cancellation WorkRequest received for request id: $requestId") | ||
| if (isVerbose) { |
There was a problem hiding this comment.
Is there any way we can hook this into a logging framework so we don't have to manually check the verbosity every time we log?
Even a helper function would be better.
There was a problem hiding this comment.
I'll add a quick function for this. We could write a logger for it, but not sure it's worth doing that unless we start doing this in more places.
We do some logger things in workers, so if I'm ever working on those again, maybe I'll change things here to use a logger.
jadenPete
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.