Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catppuccin theme #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Catppuccin theme #17

wants to merge 3 commits into from

Conversation

mudkipdev
Copy link

@lucko
Copy link
Owner

lucko commented Dec 11, 2023

Hey! thanks for the PR :)

Looks really good, thank you! I have two thoughts to run past you:

  • do we need to add all 5 themes? can we just pick the best / most popular one?
  • can we use a shorter name/id? the dropdown looks a bit weird with the super long name!

let me know what you think :)

@mudkipdev
Copy link
Author

mudkipdev commented Dec 17, 2023

Hey @lucko, sorry for the late reply, I completely forgot about this PR.

  • do we need to add all 5 themes? can we just pick the best / most popular one?

The OLED theme can be omitted as it's not an official palette and just a small community tweak that I thought would be nice to include. As for the 4 others, they are a big part of the brand and mostly ported together so I don't think keeping just one would work.

  • can we use a shorter name/id? the dropdown looks a bit weird with the super long name!

Maybe some kind of secondary dropdown system that would hide the 4 palettes until you hovered over "catppuccin"?

@lucko
Copy link
Owner

lucko commented Dec 18, 2023

Maybe some kind of secondary dropdown system that would hide the 4 palettes until you hovered over "catppuccin"?

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants